feat: CMD-56 form footer "Powered by: [tapis]" — 2nd try - #62
Open
wesleyboar wants to merge 15 commits into
Open
feat: CMD-56 form footer "Powered by: [tapis]" — 2nd try#62wesleyboar wants to merge 15 commits into
wesleyboar wants to merge 15 commits into
Conversation
…owered-by-tapis-in-footer enhance: WP-308 form footer "Powered by: [tapis]"
wesleyboar
commented
Oct 4, 2023
This was referenced Oct 4, 2023
Contributor
Author
|
Note This PR is still relevant. I track it in CMD-56. |
NotChristianGarcia
force-pushed
the
dev
branch
from
December 2, 2025 19:08
d9e1288 to
ea3308b
Compare
dev to staging
staging to prod
…ance/TUP-603-powered-by-tapis-in-footer--second-try
…by-tapis-in-footer--second-try
wesleyboar
changed the title
…ride
content_footer.html overrode the head_extra block with {{ super() }} while
being pulled in via {% include %}, which Jinja doesn't support outside an
extends chain, causing "UndefinedError: there is no parent block called
'head_extra'" on every page using it. Style now lives inline in this
partial, scoped to what it styles.
Relates-to tapis-project#61, tapis-project#62
wesleyboar
changed the title
wesleyboar
marked this pull request as ready for review
September 2, 2026 21:09
tenant.html was missing the shared content_footer include that every other redesigned form already has.
Security/Policies links stay on every form, but "Powered by: [tapis]" now only renders when the client's display_name matches the TACC User Portal (currently misconfigured as "TUP.…", eventually "TACC User Portal"), case-insensitive.
wesleyboar
commented
Sep 2, 2026
Replace the case-insensitive "tup"/"tacc user portal" substring check with an exact, case-sensitive match against "TACC User Portal".
wesleyboar
commented
Sep 2, 2026
| <a href="https://tacc.utexas.edu/use-tacc/user-policies/"> | ||
| Policies | ||
| </a> | ||
| {% if client_display_name == "TACC User Portal" %} |
Contributor
Author
There was a problem hiding this comment.
Note
This is a temporary solution to reduce testing surface area of this change to just TUP, who has expedited request for this.
* fix: hide generic Tapis logo next to TACC logo for the TACC User Portal client Reuses the footer's client_display_name check (matching "TUP" or "TACC User Portal", case-insensitive) so the header figure doesn't show the placeholder Tapis logo alongside the hardcoded TACC logo when the client is the TACC User Portal. * fix: match client_display_name exactly for Tapis-logo suppression Replace the case-insensitive "tup"/"tacc user portal" substring check with an exact, case-sensitive match against "TACC User Portal", matching the same fix applied to the footer's condition. * refactor: extract repeated header figure into content_figure.html Every form template duplicated the same tenant + hardcoded-tacc branding.html double-include inside its <figure>. Extract it into a shared partial, same pattern as content_footer.html. * refactor: move TACC User Portal check from branding.html to content_figure.html branding.html is restored to unmodified upstream content. content_figure.html now decides whether to render the tenant-specific logo at all for a TACC User Portal client, instead of branding.html only suppressing its own generic Tapis-logo fallback. This also resolves the duplicate TACC-logo case for a TUP client on the tacc tenant. * fix: indentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
For TUP client1:
Related
WP-308CMD-56Changes
Testing
For TUP client1:
UI
"TACC User Portal"
developer (
dev)generic (
apcd)Warning
Only non-TUP client developer (
dev) are genuine live screenshots; the rest oflogin/authorize/mfaare rendered with mock context, since my dev environment has no working LDAP to complete a real login flow (because #37).generic
developer (
dev)Footnotes
To reduce testing surface area to TUP client which has expedited request. Long-term, all clients get this. ↩ ↩2 ↩3