fix: hide Tapis logo next to TACC logo for TACC User Portal client - #4
Merged
wesleyboar merged 5 commits intoSep 2, 2026
Conversation
…al client Reuses the footer's client_display_name check (matching "TUP" or "TACC User Portal", case-insensitive) so the header figure doesn't show the placeholder Tapis logo alongside the hardcoded TACC logo when the client is the TACC User Portal.
Replace the case-insensitive "tup"/"tacc user portal" substring check with an exact, case-sensitive match against "TACC User Portal", matching the same fix applied to the footer's condition.
Every form template duplicated the same tenant + hardcoded-tacc branding.html double-include inside its <figure>. Extract it into a shared partial, same pattern as content_footer.html.
…igure.html branding.html is restored to unmodified upstream content. content_figure.html now decides whether to render the tenant-specific logo at all for a TACC User Portal client, instead of branding.html only suppressing its own generic Tapis-logo fallback. This also resolves the duplicate TACC-logo case for a TUP client on the tacc tenant.
wesleyboar
merged commit Sep 2, 2026
70c0ed6
into
enhance/TUP-603-powered-by-tapis-in-footer--second-try
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Hide the generic Tapis logo next to the TACC logo for TACC User Portal clients, reusing the footer's client check.
Related
Changes
client_display_namecheck to the header's Tapis-logo fallbackTesting
UI
Note
Only the TUP client "TACC User Portal" is changed.
"TACC User Portal"
generic (
apcd)developer (
dev)Warning
Only non-TUP client developer (
dev) are genuine live screenshots; the rest are rendered with mock context, since my dev environment has no working LDAP to complete a real login flow (because tapis-project#37).