-
Notifications
You must be signed in to change notification settings - Fork 5
feat: CMD-56 form footer "Powered by: [tapis]" — 2nd try #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wesleyboar
wants to merge
15
commits into
tapis-project:dev
Choose a base branch
from
wesleyboar:enhance/TUP-603-powered-by-tapis-in-footer--second-try
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
827f6b0
Merge pull request #60 from wesleyboar/enhance/TUP-603-powered-by-tap…
gcurbelo123 753f054
Merge branch 'dev' into enhance/TUP-603-powered-by-tapis-in-footer--s…
wesleyboar bd77e5e
Merge pull request #130 from tapis-project/dev
kevinpricethesecond 1f79bc2
Merge pull request #131 from tapis-project/staging
kevinpricethesecond 7096170
Merge pull request #133 from tapis-project/dev
NotChristianGarcia c4bb2e2
Merge pull request #134 from tapis-project/staging
NotChristianGarcia a0d4a7e
Merge branch 'dev' into enhance/TUP-603-powered-by-tapis-in-footer--s…
wesleyboar 75e135d
Merge pull request #143 from tapis-project/dev
NotChristianGarcia 63f7857
Merge branch 'dev' of github.com:tapis-project/authenticator into enh…
wesleyboar 083444e
Merge remote-tracking branch 'upstream' into enhance/TUP-603-powered-…
wesleyboar ebafa5d
fix: inline powered-by footer style instead of broken head_extra over…
wesleyboar 1e84186
fix: add form footer to tenant selector page
wesleyboar 98d7f75
feat: scope powered-by footer to the TACC User Portal client
wesleyboar cb6dccf
fix: match client_display_name exactly for powered-by footer element
wesleyboar 70c0ed6
fix: hide Tapis logo next to TACC logo for TACC User Portal client (#4)
wesleyboar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,6 +50,7 @@ <h1> | |
| </label> | ||
| </div> | ||
| </form> | ||
| {% include "./content_footer.html" %} | ||
| </main> | ||
| {% endblock %} | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <style> | ||
| .powered_by { | ||
| /* To move non-image links to the left */ | ||
| margin-left: auto; | ||
| } | ||
| </style> | ||
| <footer> | ||
| <a href="https://tacc.utexas.edu/about/security-and-compliance/"> | ||
| Security | ||
| </a> | ||
| <a href="https://tacc.utexas.edu/use-tacc/user-policies/"> | ||
| Policies | ||
| </a> | ||
| {% if client_display_name == "TACC User Portal" %} | ||
| <a href="https://tapis-project.org" target="_blank" class="powered_by"> | ||
| Powered by: | ||
| <img src="https://dev.develop.tapis.io/v3/oauth2/authorize/tapis.png" | ||
| alt="Tapis logo" title="Tapis (TACC APIs)" height="50px"> | ||
| </a> | ||
| {% endif %} | ||
| </footer> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
This is a temporary solution to reduce testing surface area of this change to just TUP, who has expedited request for this.