Skip to content

Revert "enhance: WP-308 form footer "Powered by: [tapis]"" - #61

Merged
gcurbelo123 merged 1 commit into
tapis-project:devfrom
wesleyboar:revert-60-enhance/TUP-603-powered-by-tapis-in-footer
Oct 4, 2023
Merged

Revert "enhance: WP-308 form footer "Powered by: [tapis]""#61
gcurbelo123 merged 1 commit into
tapis-project:devfrom
wesleyboar:revert-60-enhance/TUP-603-powered-by-tapis-in-footer

Conversation

@wesleyboar

@wesleyboar wesleyboar commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

Overview

Revert #60 to fix Jinja bug it causes —

{"message":"Unrecognized exception type: <class 'jinja2.exceptions.UndefinedError'>. Exception: there is no parent block called 'head_extra'.","metadata":{},"result":null,"status":"error","version":"dev"}

— so Portal team can login to dev.

Related

Testing

  1. Load project website.
  2. Open any redesigned form.
  3. Verify form loads.

UI

before after
error

@gcurbelo123
gcurbelo123 merged commit 5b66861 into tapis-project:dev Oct 4, 2023
@wesleyboar
wesleyboar deleted the revert-60-enhance/TUP-603-powered-by-tapis-in-footer branch October 4, 2023 16:22
wesleyboar added a commit to wesleyboar/tapis-project-authenticator that referenced this pull request Sep 2, 2026
…ride

content_footer.html overrode the head_extra block with {{ super() }} while
being pulled in via {% include %}, which Jinja doesn't support outside an
extends chain, causing "UndefinedError: there is no parent block called
'head_extra'" on every page using it. Style now lives inline in this
partial, scoped to what it styles.

Relates-to tapis-project#61, tapis-project#62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants