[PM-32833] Remove Input Password Feature Flag

[rr-bw]

🎟️ Tracking

PM-32833

📔 Objective

This PR removes the pm-27086-update-authentication-apis-for-input-password feature flag.

Important

This is the base branch for the feature flag removal work. This branch accumulates all the changes on the sub-PRs, each of which has already been reviewed individually.

PR Status:

• [PM-32833] Remove Input Password Feature Flag #20306 - 🟢 This PR (accumulates sub-PRs)
  • [PM-32833] Remove Input Password Flag from RegistrationFinishService #20244
  • [PM-32833] Remove Input Password Flag from SetInitialPasswordComponent #20246
  • [PM-32833] Remove Input Password Flag from Change Password #20308
  • [PM-32833] Remove Input Password Flag from Emergency Access #20291
  • [PM-32833] Remove Input Password Flag from Account Recovery #20292
  • [PM-32833] Remove Input Password Flag from InputPasswordComponent #20475

Local smoke testing shows consistent functionality.

[codecov]

Codecov Report

❌ Patch coverage is 67.69231% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.02%. Comparing base (72f082b) to head (72ece52).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...initial-password/set-initial-password.component.ts	0.00%	11 Missing ⚠️
...ement/change-password/change-password.component.ts	0.00%	5 Missing ⚠️
...ls/request/registration/register-finish.request.ts	0.00%	2 Missing ⚠️
...angular/input-password/input-password.component.ts	0.00%	1 Missing ⚠️
...c/angular/input-password/input-password.stories.ts	0.00%	1 Missing ⚠️
...tion-finish/default-registration-finish.service.ts	91.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #20306      +/-   ##
==========================================
- Coverage   47.02%   47.02%   -0.01%     
==========================================
  Files        3951     3950       -1     
  Lines      119648   119467     -181     
  Branches    18325    18287      -38     
==========================================
- Hits        56265    56179      -86     
+ Misses      59141    59048      -93     
+ Partials     4242     4240       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Checkmarx One – Scan Summary & Details – af3cacac-d888-484d-bd27-6dca44a5f69f

Great job! No new security vulnerabilities introduced in this pull request

[github-actions]

Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR removes the pm-27086-update-authentication-apis-for-input-password feature flag and consolidates 6 already-reviewed sub-PRs. The off-flag code paths are deleted across the registration, change-password, set-initial-password, emergency access takeover, and organization user reset flows. RegisterFinishRequest is restructured to carry MasterPasswordAuthenticationData and MasterPasswordUnlockData directly (replacing the now-deleted RegisterFinishRequestWithAuthUnlockDataTypes), and tests are rewritten to drop flag-based describe blocks. Verified that syncService.fullSync(true) is still invoked inside WebChangePasswordService.changePasswordAndRotateUserKey() after its removal from ChangePasswordComponent, and that all previously-deleted symbols (PM27086_UpdateAuthenticationApisForInputPassword, RegisterFinishRequestWithAuthUnlockDataTypes, setInitialPasswordTdeOffboardingOld, SetInitialPasswordTdeOffboardingCredentialsOld, newApisWithInputPasswordFlagEnabled) have no remaining references.

Code Review Details

No findings.

The deprecated PasswordInputResult.newMasterKey / newServerMasterKeyHash fields and the JIT_PROVISIONED_MP_ORG_USER master-key derivation in SetInitialPasswordComponent are intentionally retained per the inline comment referencing PM-32526.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[r-tome]

AC changes look good

[dereknance]

✅ Platform