Skip to content

[PM-32833] Remove Input Password Flag from InputPasswordComponent#20475

Merged
rr-bw merged 5 commits intoauth/pm-32833/remove-input-password-flag-basefrom
auth/pm-32833/input-password-component
May 5, 2026
Merged

[PM-32833] Remove Input Password Flag from InputPasswordComponent#20475
rr-bw merged 5 commits intoauth/pm-32833/remove-input-password-flag-basefrom
auth/pm-32833/input-password-component

Conversation

@rr-bw
Copy link
Copy Markdown
Contributor

@rr-bw rr-bw commented May 1, 2026

🎟️ Tracking

PM-32833

📔 Objective

This PR removes pm-27086-update-authentication-apis-for-input-password feature flag usage from the InputPasswordComponent and related files.


Note

This PR is part of a larger group of PRs (split up for easier review) that will each get merged into a base branch for this flag removal work: auth/pm-32833/remove-input-password-flag-base (base PR). That base branch is the one that will get merged to main.

Breakdown of branching structure:

main
 └── auth/pm-32833/remove-input-password-flag-base  ← targets main; accumulates sub-PRs
     ├── auth/pm-32833/registration-finish            ← targets base
     ├── auth/pm-32833/set-initial-password           ← targets base
     ├── auth/pm-32833/change-password                ← targets base
     ├── auth/pm-32833/emergency-access               ← targets base
     ├── auth/pm-32833/account-recovery               ← targets base
     └── auth/pm-32833/input-password-component       ← targets base; reviewed LAST [THIS PR 🟢]

@rr-bw rr-bw changed the base branch from main to auth/pm-32833/remove-input-password-flag-base May 1, 2026 18:07
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.11%. Comparing base (1d2e9a1) to head (3272f19).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...angular/input-password/input-password.component.ts 0.00% 1 Missing ⚠️
...c/angular/input-password/input-password.stories.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                              Coverage Diff                               @@
##           auth/pm-32833/remove-input-password-flag-base   #20475   +/-   ##
==============================================================================
  Coverage                                          47.10%   47.11%           
==============================================================================
  Files                                               3949     3949           
  Lines                                             119569   119544   -25     
  Branches                                           18315    18310    -5     
==============================================================================
  Hits                                               56323    56323           
+ Misses                                             59012    58986   -26     
- Partials                                            4234     4235    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rr-bw rr-bw closed this May 1, 2026
@rr-bw rr-bw reopened this May 1, 2026
@rr-bw rr-bw added the ai-review Request a Claude code review label May 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR removes the PM27086_UpdateAuthenticationApisForInputPassword feature flag from InputPasswordComponent, deleting the legacy "flag-off" branch that called KeyService.makeMasterKey / hashMasterKey directly. The retained path matches the previous "flag-on" behavior, and ConfigService plus KeyService are correctly removed from the component constructor and the storybook providers. Consumer call sites (SetInitialPasswordComponent, RegistrationFinishComponent, ChangePasswordComponent, emergency access / account recovery flows) were already migrated in earlier sub-PRs of the auth/pm-32833/remove-input-password-flag-base chain — no dangling references to the removed currentMasterKey, currentServerMasterKeyHash, or newApisWithInputPasswordFlagEnabled properties remain in the codebase. The flag is also paired-removed from both FeatureFlag and DefaultFeatureFlagValue.

Code Review Details

No findings. The deprecated newMasterKey / newServerMasterKeyHash properties on PasswordInputResult are intentionally preserved for the JIT_PROVISIONED_MP_ORG_USER flow per the inline doc comments (slated for removal in PM-32526), and SetInitialPasswordComponent continues to populate them itself — the contract is consistent.

@rr-bw rr-bw removed the ai-review Request a Claude code review label May 4, 2026
@rr-bw rr-bw force-pushed the auth/pm-32833/input-password-component branch from 4c52678 to 3272f19 Compare May 4, 2026 15:43
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

@rr-bw rr-bw marked this pull request as ready for review May 4, 2026 16:34
@rr-bw rr-bw requested a review from a team as a code owner May 4, 2026 16:34
@rr-bw rr-bw requested a review from enmande May 4, 2026 16:34
@rr-bw rr-bw merged commit 4b42746 into auth/pm-32833/remove-input-password-flag-base May 5, 2026
125 checks passed
@rr-bw rr-bw deleted the auth/pm-32833/input-password-component branch May 5, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants