Skip to content

[PM-32833] Remove Input Password Flag from Account Recovery#20292

Merged
rr-bw merged 1 commit intoauth/pm-32833/remove-input-password-flag-basefrom
auth/pm-32833/account-recovery
Apr 27, 2026
Merged

[PM-32833] Remove Input Password Flag from Account Recovery#20292
rr-bw merged 1 commit intoauth/pm-32833/remove-input-password-flag-basefrom
auth/pm-32833/account-recovery

Conversation

@rr-bw
Copy link
Copy Markdown
Contributor

@rr-bw rr-bw commented Apr 20, 2026

🎟️ Tracking

PM-32833

📔 Objective

This PR removes pm-27086-update-authentication-apis-for-input-password feature flag usage from the OrganizationUserResetPasswordService and related files.


Note

This PR is part of a larger group of PRs (split up for easier review) that will each get merged into a base branch for this flag removal work: auth/pm-32833/remove-input-password-flag-base (base PR). That base branch is the one that will get merged to main.

Breakdown of branching structure:

main
 └── auth/pm-32833/remove-input-password-flag-base  ← targets main; accumulates sub-PRs
     ├── auth/pm-32833/registration-finish            ← targets base
     ├── auth/pm-32833/set-initial-password           ← targets base
     ├── auth/pm-32833/change-password                ← targets base
     ├── auth/pm-32833/emergency-access               ← targets base
     ├── auth/pm-32833/account-recovery               ← targets base [THIS PR 🟢]
     └── auth/pm-32833/input-password-component       ← targets base; reviewed LAST

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.99%. Comparing base (e389fe4) to head (433f11e).
⚠️ Report is 1 commits behind head on auth/pm-32833/remove-input-password-flag-base.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                                Coverage Diff                                @@
##           auth/pm-32833/remove-input-password-flag-base   #20292      +/-   ##
=================================================================================
- Coverage                                          47.00%   46.99%   -0.01%     
=================================================================================
  Files                                               3912     3912              
  Lines                                             118322   118314       -8     
  Branches                                           18089    18088       -1     
=================================================================================
- Hits                                               55613    55605       -8     
  Misses                                             58522    58522              
  Partials                                            4187     4187              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Details2b57bd0c-73dd-40ac-970e-9870b135da55

Great job! No new security vulnerabilities introduced in this pull request

@rr-bw rr-bw changed the base branch from main to auth/pm-32833/remove-input-password-flag-base April 21, 2026 20:28
@rr-bw rr-bw added the ai-review Request a Claude code review label Apr 24, 2026
@rr-bw rr-bw force-pushed the auth/pm-32833/account-recovery branch from 0dda736 to 433f11e Compare April 24, 2026 17:29
@rr-bw rr-bw marked this pull request as ready for review April 27, 2026 16:04
@rr-bw rr-bw requested a review from a team as a code owner April 27, 2026 16:04
@rr-bw rr-bw requested a review from sven-bitwarden April 27, 2026 16:04
@rr-bw rr-bw merged commit d74b66a into auth/pm-32833/remove-input-password-flag-base Apr 27, 2026
50 of 54 checks passed
@rr-bw rr-bw deleted the auth/pm-32833/account-recovery branch April 27, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants