[PM-32833] Remove Input Password Flag from RegistrationFinishService

[rr-bw]

🎟️ Tracking

PM-32833

📔 Objective

This PR removes pm-27086-update-authentication-apis-for-input-password feature flag usage from the DefaultRegistrationFinishService and related files.

Note

This PR is part of a larger group of PRs (split up for easier review) that will each get merged into a base branch for this flag removal work: auth/pm-32833/remove-input-password-flag-base (base PR). That base branch is the one that will get merged to main.

Breakdown of branching structure:

main
 └── auth/pm-32833/remove-input-password-flag-base  ← targets main; accumulates sub-PRs
     ├── auth/pm-32833/registration-finish            ← targets base [THIS PR 🟢]
     ├── auth/pm-32833/set-initial-password           ← targets base
     ├── auth/pm-32833/change-password                ← targets base
     ├── auth/pm-32833/emergency-access               ← targets base
     ├── auth/pm-32833/account-recovery               ← targets base
     └── auth/pm-32833/input-password-component       ← targets base; reviewed LAST

[codecov]

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.08%. Comparing base (71967ef) to head (b172ab9).
⚠️ Report is 1 commits behind head on auth/pm-32833/remove-input-password-flag-base.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ls/request/registration/register-finish.request.ts	0.00%	2 Missing ⚠️
...tion-finish/default-registration-finish.service.ts	91.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@                                Coverage Diff                                @@
##           auth/pm-32833/remove-input-password-flag-base   #20244      +/-   ##
=================================================================================
- Coverage                                          47.08%   47.08%   -0.01%     
=================================================================================
  Files                                               3938     3937       -1     
  Lines                                             119473   119444      -29     
  Branches                                           18321    18317       -4     
=================================================================================
- Hits                                               56255    56241      -14     
+ Misses                                             58955    58940      -15     
  Partials                                            4263     4263              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Checkmarx One – Scan Summary & Details – 7d373117-1daf-42fc-8607-6813a92d0853

Great job! No new security vulnerabilities introduced in this pull request

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Removes the pm-27086-update-authentication-apis-for-input-password feature flag from DefaultRegistrationFinishService and WebRegistrationFinishService, consolidating the registration request into a single RegisterFinishRequest shape that carries MasterPasswordAuthenticationData and MasterPasswordUnlockData. The legacy RegisterFinishRequestWithAuthUnlockDataTypes model is deleted, the now-unused ConfigService and EncryptedString dependencies are dropped, and DI providers in both core.module.ts and jslib-services.module.ts are updated to match the new constructor shapes. Tests, snapshots, and assertions for newPassword, salt, and kdfConfig are updated accordingly, and the flow remains compatible with the upstream InputPasswordComponent regardless of the still-flagged emission path (which is scheduled for removal in PM-28143 per the PR's branching plan).

Code Review Details

No findings.

[coroiu]

Approving removal of ConfigService as dependency for RegistrationFinishServiceAbstraction in core.module.ts

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[JaredSnider-Bitwarden]

Nice work!