Skip to content

[PM-32833] Remove Input Password Flag from RegistrationFinishService #20244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rr-bw merged 6 commits into from
May 1, 2026
Merged

[PM-32833] Remove Input Password Flag from RegistrationFinishService #20244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1e30724
remove from RegistrationFinishService and update related files
rr-bw Apr 14, 2026
a9df659
regenerate snapshot tests for web and default RegistrationFinishService
rr-bw Apr 17, 2026
775346d
add test coverage for missing properties on PasswordInputResult
rr-bw Apr 21, 2026
32aa9e4
update tests to remove old/new distinction since the 'new' pattern is…
rr-bw Apr 23, 2026
930a61a
rename RegisterFinishRequestWithAuthUnlockDataTypes to RegisterFinish…
rr-bw Apr 23, 2026
b172ab9
Merge branch 'auth/pm-32833/remove-input-password-flag-base' into aut…
rr-bw Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 9 additions & 134 deletions ...uth/core/services/registration/__snapshots__/web-registration-finish.service.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,132 +1,7 @@
// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing

exports[`WebRegistrationFinishService finishRegistration() when feature flag is OFF (old API) it registers the user with org invite when given an org invite 1`] = `
RegisterFinishRequest {
"acceptEmergencyAccessId": undefined,
"acceptEmergencyAccessInviteToken": undefined,
"email": "test@email.com",
"emailVerificationToken": undefined,
"kdf": 0,
"kdfIterations": 600000,
"kdfMemory": undefined,
"kdfParallelism": undefined,
"masterPasswordHash": "newServerMasterKeyHash",
"masterPasswordHint": "newPasswordHint",
"orgInviteToken": "orgInviteToken",
"orgSponsoredFreeFamilyPlanToken": undefined,
"organizationUserId": "organizationUserId",
"providerInviteToken": undefined,
"providerUserId": undefined,
"userAsymmetricKeys": KeysRequest {
"encryptedPrivateKey": "privateKey",
"publicKey": "publicKey",
},
"userSymmetricKey": "userKeyEncrypted",
}
`;

exports[`WebRegistrationFinishService finishRegistration() when feature flag is OFF (old API) registers the user when given a provider invite token 1`] = `
RegisterFinishRequest {
"acceptEmergencyAccessId": undefined,
"acceptEmergencyAccessInviteToken": undefined,
"email": "test@email.com",
"emailVerificationToken": undefined,
"kdf": 0,
"kdfIterations": 600000,
"kdfMemory": undefined,
"kdfParallelism": undefined,
"masterPasswordHash": "newServerMasterKeyHash",
"masterPasswordHint": "newPasswordHint",
"orgInviteToken": undefined,
"orgSponsoredFreeFamilyPlanToken": undefined,
"organizationUserId": undefined,
"providerInviteToken": "providerInviteToken",
"providerUserId": "providerUserId",
"userAsymmetricKeys": KeysRequest {
"encryptedPrivateKey": "privateKey",
"publicKey": "publicKey",
},
"userSymmetricKey": "userKeyEncrypted",
}
`;

exports[`WebRegistrationFinishService finishRegistration() when feature flag is OFF (old API) registers the user when given an emergency access invite token 1`] = `
RegisterFinishRequest {
"acceptEmergencyAccessId": "emergencyAccessId",
"acceptEmergencyAccessInviteToken": "acceptEmergencyAccessInviteToken",
"email": "test@email.com",
"emailVerificationToken": undefined,
"kdf": 0,
"kdfIterations": 600000,
"kdfMemory": undefined,
"kdfParallelism": undefined,
"masterPasswordHash": "newServerMasterKeyHash",
"masterPasswordHint": "newPasswordHint",
"orgInviteToken": undefined,
"orgSponsoredFreeFamilyPlanToken": undefined,
"organizationUserId": undefined,
"providerInviteToken": undefined,
"providerUserId": undefined,
"userAsymmetricKeys": KeysRequest {
"encryptedPrivateKey": "privateKey",
"publicKey": "publicKey",
},
"userSymmetricKey": "userKeyEncrypted",
}
`;

exports[`WebRegistrationFinishService finishRegistration() when feature flag is OFF (old API) registers the user when given an org sponsored free family plan token 1`] = `
RegisterFinishRequest {
"acceptEmergencyAccessId": undefined,
"acceptEmergencyAccessInviteToken": undefined,
"email": "test@email.com",
"emailVerificationToken": undefined,
"kdf": 0,
"kdfIterations": 600000,
"kdfMemory": undefined,
"kdfParallelism": undefined,
"masterPasswordHash": "newServerMasterKeyHash",
"masterPasswordHint": "newPasswordHint",
"orgInviteToken": undefined,
"orgSponsoredFreeFamilyPlanToken": "orgSponsoredFreeFamilyPlanToken",
"organizationUserId": undefined,
"providerInviteToken": undefined,
"providerUserId": undefined,
"userAsymmetricKeys": KeysRequest {
"encryptedPrivateKey": "privateKey",
"publicKey": "publicKey",
},
"userSymmetricKey": "userKeyEncrypted",
}
`;

exports[`WebRegistrationFinishService finishRegistration() when feature flag is OFF (old API) registers the user with KDF fields when given valid email verification input 1`] = `
exports[`WebRegistrationFinishService finishRegistration() derives the master key and registers the user 1`] = `
RegisterFinishRequest {
"acceptEmergencyAccessId": undefined,
"acceptEmergencyAccessInviteToken": undefined,
"email": "test@email.com",
"emailVerificationToken": "emailVerificationToken",
"kdf": 0,
"kdfIterations": 600000,
"kdfMemory": undefined,
"kdfParallelism": undefined,
"masterPasswordHash": "newServerMasterKeyHash",
"masterPasswordHint": "newPasswordHint",
"orgInviteToken": undefined,
"orgSponsoredFreeFamilyPlanToken": undefined,
"organizationUserId": undefined,
"providerInviteToken": undefined,
"providerUserId": undefined,
"userAsymmetricKeys": KeysRequest {
"encryptedPrivateKey": "privateKey",
"publicKey": "publicKey",
},
"userSymmetricKey": "userKeyEncrypted",
}
`;

exports[`WebRegistrationFinishService finishRegistration() when feature flag is ON (new API) derives the master key and registers the user with new data types 1`] = `
RegisterFinishRequestWithAuthUnlockDataTypes {
"acceptEmergencyAccessId": undefined,
"acceptEmergencyAccessInviteToken": undefined,
"email": "test@email.com",
Expand Down Expand Up @@ -160,8 +35,8 @@ RegisterFinishRequestWithAuthUnlockDataTypes {
}
`;

exports[`WebRegistrationFinishService finishRegistration() when feature flag is ON (new API) it registers the user with org invite when given an org invite 1`] = `
RegisterFinishRequestWithAuthUnlockDataTypes {
exports[`WebRegistrationFinishService finishRegistration() it registers the user with org invite when given an org invite 1`] = `
RegisterFinishRequest {
"acceptEmergencyAccessId": undefined,
"acceptEmergencyAccessInviteToken": undefined,
"email": "test@email.com",
Expand Down Expand Up @@ -195,8 +70,8 @@ RegisterFinishRequestWithAuthUnlockDataTypes {
}
`;

exports[`WebRegistrationFinishService finishRegistration() when feature flag is ON (new API) registers the user when given a provider invite token 1`] = `
RegisterFinishRequestWithAuthUnlockDataTypes {
exports[`WebRegistrationFinishService finishRegistration() registers the user when given a provider invite token 1`] = `
RegisterFinishRequest {
"acceptEmergencyAccessId": undefined,
"acceptEmergencyAccessInviteToken": undefined,
"email": "test@email.com",
Expand Down Expand Up @@ -230,8 +105,8 @@ RegisterFinishRequestWithAuthUnlockDataTypes {
}
`;

exports[`WebRegistrationFinishService finishRegistration() when feature flag is ON (new API) registers the user when given an emergency access invite token 1`] = `
RegisterFinishRequestWithAuthUnlockDataTypes {
exports[`WebRegistrationFinishService finishRegistration() registers the user when given an emergency access invite token 1`] = `
RegisterFinishRequest {
"acceptEmergencyAccessId": "emergencyAccessId",
"acceptEmergencyAccessInviteToken": "acceptEmergencyAccessInviteToken",
"email": "test@email.com",
Expand Down Expand Up @@ -265,8 +140,8 @@ RegisterFinishRequestWithAuthUnlockDataTypes {
}
`;

exports[`WebRegistrationFinishService finishRegistration() when feature flag is ON (new API) registers the user when given an org sponsored free family plan token 1`] = `
RegisterFinishRequestWithAuthUnlockDataTypes {
exports[`WebRegistrationFinishService finishRegistration() registers the user when given an org sponsored free family plan token 1`] = `
RegisterFinishRequest {
"acceptEmergencyAccessId": undefined,
"acceptEmergencyAccessInviteToken": undefined,
"email": "test@email.com",
Expand Down
Loading
Loading