next/484/20240615/v1#11309
Merged
Merged
Conversation
No need to init ptrs to NULL after SCCalloc.
Implement special "isset" and "isnotset" modes. "isset" matches if an IP address is part of an iprep category with any value. It is internally implemented as ">=,0", which should always be true if there is a value to evaluate, as valid reputation values are 0-127. "isnotset" matches if an IP address is not part of an iprep category. Internally it is implemented outside the uint support. Ticket: OISF#6857.
Bring in line with new Rust code naming for FFI functions.
When replaying a pcap file, it is not possible to get rules profiling because it has to be activated from the unix socket. This patch adds a new option to be able to activate profiling collection at start so a pcap run can get rules profiling information.
This fixes the state handling and simplify the logic.
As the function SCEnipRegisterParsers is already marked as unsafe
detect: make number of keywords dynamic Ticket: 4683
Ticket: 4863 On the way, convert unit test DetectSNMPCommunityTest to a SV test. And also, make snmp.pdu_type use a generic uint32 for detection, allowing operators, instead of just equality.
Ticket: 4863
Ticket: 4863
Ticket: 4863
"default_features" is being deprecated in Rust 2024.
New warning from rustc. The other option is to allow dead code, however this is more explicit, and when they are read, its obvious they should be renamed.
victorjulien
requested review from
a team,
jasonish and
jufajardini
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11309 +/- ##
==========================================
+ Coverage 82.45% 82.47% +0.01%
==========================================
Files 961 934 -27
Lines 251710 252270 +560
==========================================
+ Hits 207552 208055 +503
- Misses 44158 44215 +57
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING: ERROR: QA failed on SURI_TLPR1_suri_time.
Pipeline 21097 |
|
Information: QA ran without warnings. Pipeline 21100 |
This was referenced Jun 16, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#1918