enip: remove unnecessary unsafe#11290
Closed
catenacyber wants to merge 1 commit into
Closed
Conversation
As the function SCEnipRegisterParsers is already marked as unsafe
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11290 +/- ##
==========================================
- Coverage 82.45% 82.45% -0.01%
==========================================
Files 961 961
Lines 251710 251708 -2
==========================================
- Hits 207552 207536 -16
- Misses 44158 44172 +14
Flags with carried forward coverage won't be shown. Click here to find out more. |
lukashino
approved these changes
Jun 11, 2024
|
Information: ERROR: QA failed on SURI_TLPW2_autofp_suri_time. ERROR: QA failed on SURI_TLPR1_suri_time.
Pipeline 21061 |
victorjulien
approved these changes
Jun 15, 2024
Merged
Member
|
Merged in #11309, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/3958 simple follow up
Describe changes:
cargo updateon MSRV happy