Skip to content

enip: remove unnecessary unsafe#11290

Closed
catenacyber wants to merge 1 commit into
OISF:masterfrom
catenacyber:enip-unsafe-v1
Closed

enip: remove unnecessary unsafe#11290
catenacyber wants to merge 1 commit into
OISF:masterfrom
catenacyber:enip-unsafe-v1

Conversation

@catenacyber
Copy link
Copy Markdown
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/3958 simple follow up

Describe changes:

  • enip: remove unnecessary unsafe to make cargo update on MSRV happy
error: unnecessary `unsafe` block
   --> src/enip/enip.rs:637:9
    |
585 | pub unsafe extern "C" fn SCEnipRegisterParsers() {
    | ------------------------------------------------ because it's nested under this `unsafe` fn
...
637 |         unsafe {
    |         ^^^^^^ unnecessary `unsafe` block
    |

As the function SCEnipRegisterParsers is already marked as unsafe
@catenacyber catenacyber requested a review from jasonish as a code owner June 11, 2024 10:45
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.45%. Comparing base (f0dbfe8) to head (f47ac2b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11290      +/-   ##
==========================================
- Coverage   82.45%   82.45%   -0.01%     
==========================================
  Files         961      961              
  Lines      251710   251708       -2     
==========================================
- Hits       207552   207536      -16     
- Misses      44158    44172      +14     
Flag Coverage Δ
fuzzcorpus 60.30% <100.00%> (-0.01%) ⬇️
livemode 18.68% <100.00%> (-0.01%) ⬇️
pcap 43.76% <0.00%> (-0.03%) ⬇️
suricata-verify 61.16% <100.00%> (-0.02%) ⬇️
unittests 59.96% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link
Copy Markdown

Information:

ERROR: QA failed on SURI_TLPW2_autofp_suri_time.

ERROR: QA failed on SURI_TLPR1_suri_time.

field baseline test %
SURI_TLPW2_autofp_stats_chk
.uptime 137 144 105.11%
SURI_TLPR1_stats_chk
.uptime 642 688 107.17%

Pipeline 21061

@victorjulien victorjulien added this to the 8.0 milestone Jun 15, 2024
@victorjulien
Copy link
Copy Markdown
Member

Merged in #11309, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants