profiling: activate when Suricata starts in pcap reader mode#11282
Closed
jlucovsky wants to merge 2 commits into
Closed
profiling: activate when Suricata starts in pcap reader mode#11282jlucovsky wants to merge 2 commits into
jlucovsky wants to merge 2 commits into
Conversation
When replaying a pcap file, it is not possible to get rules profiling because it has to be activated from the unix socket. This patch adds a new option to be able to activate profiling collection at start so a pcap run can get rules profiling information.
This fixes the state handling and simplify the logic.
|
Information: QA ran without warnings. Pipeline 21032 |
victorjulien
approved these changes
Jun 10, 2024
Merged
Member
|
Merged in #11309, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #9755
Activate rule profiling on Suricata startup with a new config variable:
Link to ticket: https://redmine.openinfosecfoundation.org/issues/6550
Describe changes:
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=