Detect dynamic register keywords 4683 v6#11291
Closed
catenacyber wants to merge 5 commits into
Closed
Conversation
detect: make number of keywords dynamic Ticket: 4683
Ticket: 4863 On the way, convert unit test DetectSNMPCommunityTest to a SV test. And also, make snmp.pdu_type use a generic uint32 for detection, allowing operators, instead of just equality.
Ticket: 4863
Ticket: 4863
Ticket: 4863
catenacyber
requested review from
a team,
jasonish,
jufajardini and
victorjulien
as code owners
catenacyber
force-pushed
the
detect-dynamic-register-keywords-4683-v6
branch
from
c4fe3dd to
9048cff
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11291 +/- ##
==========================================
- Coverage 82.45% 78.99% -3.47%
==========================================
Files 961 934 -27
Lines 251710 251970 +260
==========================================
- Hits 207552 199043 -8509
- Misses 44158 52927 +8769
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 21059 |
victorjulien
approved these changes
Jun 15, 2024
Member
victorjulien
left a comment
victorjulien
left a comment
There was a problem hiding this comment.
Nice work, lets get this merged.
One follow up request: I don't like the now dynamic DETECT_TBLSIZE_IDX and friends as all uppercase. That we normally reserve for macros/defines.
Merged
Member
|
Merged in #11309, thanks! |
This was referenced Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4683
Describe changes:
>2and suchContinuation of #9871 after merge of #10819
After the merge of loggers, pure rust plugins need pure rust keywords.
The plan is to do this for all rust app-layers, now only done for 4 protocols, which has both integers and buffers as keywords.
This can come in later PRs
Then, there will be the final PR/commits for app-layer plugins
#11068 rebased with enip after merge of #11218 for build fixes