Skip to content

fix(workspace): widen unified new-session menu so "New worktree config" fits (#10269) #10588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxmilian wants to merge 1 commit into from
+5 −5
Closed

fix(workspace): widen unified new-session menu so "New worktree config" fits (#10269) #10588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/src/workspace/view.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,10 +253,7 @@ use crate::drive::{
CloudObjectTypeAndId, DriveObjectType, DrivePanel, DrivePanelEvent, OpenWarpDriveObjectSettings,
};
use crate::experiments::{BlockOnboarding, Experiment};
use crate::menu::{
Event as MenuEvent, Menu, MenuItem, MenuItemFields, MenuSelectionSource,
DEFAULT_WIDTH as MENU_DEFAULT_WIDTH,
};
use crate::menu::{Event as MenuEvent, Menu, MenuItem, MenuItemFields, MenuSelectionSource};
use crate::modal::{Modal, ModalEvent, ModalViewState};
use crate::network::{NetworkStatus, NetworkStatusEvent};
use crate::notebooks::manager::{NotebookManager, NotebookSource};
Expand Down Expand Up @@ -6316,7 +6313,10 @@ impl Workspace {
// Match the Figma mock width (OptionMenuItem component is 268px).
context_menu.set_width(268.);
} else {
context_menu.set_width(MENU_DEFAULT_WIDTH);
// Horizontal variant renders the same items, so it needs the
// same 268px to avoid clipping "New worktree config" — the
// global MENU_DEFAULT_WIDTH (186px) was too narrow. See #10269.
context_menu.set_width(268.);
}
context_menu.set_items(menu_items, view_ctx);
match open_source {
Expand Down