fix(workspace): widen unified new-session menu so "New worktree config" fits (#10269)#10588
fix(workspace): widen unified new-session menu so "New worktree config" fits (#10269)#10588maxmilian wants to merge 1 commit intowarpdotdev:masterfrom
Conversation
…g" fits (warpdotdev#10269) The unified new-session/tab config menu rendered the same items in both horizontal and vertical tab modes, but only the vertical-tabs branch set the width to 268px (the OptionMenuItem Figma spec); the horizontal branch fell back to MENU_DEFAULT_WIDTH = 186px, which is too narrow for the "New worktree config" label and clipped it at the right edge. Apply the same 268px width in the horizontal branch. The MENU_DEFAULT_WIDTH import is no longer needed and is removed.
github-actions
Bot
added
the
external-contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
|
Closing as a duplicate of #10542 — I missed the existing PR when I searched issue #10269 references. Apologies for the noise; @SagarSDagdu PR addresses the same WorkspaceView::open_tab_configs_menu width-fallback root cause. |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR removes the now-unused default menu width import and sets the horizontal new-session menu width to 268px to match the vertical-tabs variant.
Concerns
- Manual testing is required for changes that can be manually tested. Please include screenshots or a screen recording that show it working end to end, or justify why manual testing is not possible. The current Screenshots / Videos section only contains a placeholder.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
1 participant
Description
The unified new-session/tab config menu opened from the tab bar
+chevron rendered the same items in both horizontal and vertical tab modes, but only the vertical-tabs branch ofWorkspaceView::open_tab_configs_menuset the menu width to 268px (the OptionMenuItem Figma spec). The horizontal branch fell back toMENU_DEFAULT_WIDTH(186px), which was too narrow for theNew worktree configlabel and clipped it at the right edge of the menu.This PR sets the horizontal branch to the same 268px width so the label fits in both tab orientations. The now-unused
MENU_DEFAULT_WIDTHimport is removed.Linked Issue
Fixes #10269.
ready-to-specorready-to-implement.Testing
./script/runBuilt
WarpOss.appfrom this branch, opened the tab bar+chevron menu in horizontal-tabs mode (the variant in the issue's repro), and confirmedNew worktree configis now displayed in full with the submenu chevron visible at the right edge — no clipping.Screenshots / Videos
After (this PR — horizontal tabs
+chevron menu):The "before" state is in the issue body (image link
84a133db-cd00-4e93-8a62-5e1ccb08a84f).Agent Mode