Skip to content

Update script to use snapshot builds in integration tests - #1691

Merged
msridhar merged 1 commit into
masterfrom
update-snapshot-build-script
Aug 10, 2026
Merged

Update script to use snapshot builds in integration tests#1691
msridhar merged 1 commit into
masterfrom
update-snapshot-build-script

Conversation

@msridhar

@msridhar msridhar commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Now the script works in the presence of isolated projects, which were recently enabled by JUnit.

Summary by CodeRabbit

  • Refactor
    • Improved internal build configuration for more consistent dependency resolution.
    • Renamed an internal generic-call inference result type without changing public behavior.

@msridhar

msridhar commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator Author

@msridhar
msridhar requested a review from yuxincs August 9, 2026 18:20
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.87%. Comparing base (7489d69) to head (19779b5).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1691   +/-   ##
=========================================
  Coverage     87.87%   87.87%           
  Complexity     3167     3167           
=========================================
  Files           109      109           
  Lines         10739    10739           
  Branches       2171     2171           
=========================================
  Hits           9437     9437           
  Misses          617      617           
  Partials        685      685           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The Gradle init script now applies repository and dependency-resolution setup in gradle.lifecycle.beforeProject. It replaces configurations.all with configurations.configureEach. NullAway dependencies continue to use dynamic + versions, with changing and dynamic-version caches disabled. GenericsChecks renames its private inference result interface to CallInferenceResult and updates related cache and inference usages.

Possibly related PRs

  • uber/NullAway#1690: Applies the same MethodInferenceResult to CallInferenceResult rename in GenericsChecks.java.
  • uber/NullAway#1251: Modifies the same snapshot Gradle script and dynamic-version cache configuration.
  • uber/NullAway#1312: Changes generic inference handling in GenericsChecks.java.

Suggested reviewers: yuxincs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change to use snapshot builds in integration tests.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-snapshot-build-script

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/use-snapshot.gradle.kts:
- Line 2: Ensure the workflow validates that the consumer repository’s Gradle
version is at least 8.8 before copying or applying the init script containing
gradle.lifecycle.beforeProject; otherwise, make that script compatible with
older supported wrappers while preserving its behavior.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a7d65af0-1fd8-4185-8df9-1ffe70b2579b

📥 Commits

Reviewing files that changed from the base of the PR and between 7489d69 and 19779b5.

📒 Files selected for processing (1)
  • .github/workflows/use-snapshot.gradle.kts

Comment thread .github/workflows/use-snapshot.gradle.kts
@msridhar
msridhar merged commit 741fbad into master Aug 10, 2026
22 checks passed
@msridhar
msridhar deleted the update-snapshot-build-script branch August 10, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants