Skip to content

Rename MethodInferenceResult to CallInferenceResult - #1690

Merged
msridhar merged 1 commit into
update-snapshot-build-scriptfrom
rename-to-callinferenceresult
Aug 9, 2026
Merged

Rename MethodInferenceResult to CallInferenceResult#1690
msridhar merged 1 commit into
update-snapshot-build-scriptfrom
rename-to-callinferenceresult

Conversation

@msridhar

@msridhar msridhar commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Refactoring in preparation for #1544

Summary by CodeRabbit

  • Refactor
    • Renamed an internal generic-call inference abstraction and related references without changing inference behavior.
    • No user-visible functionality or public API changes.

@msridhar

msridhar commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator Author

@msridhar
msridhar requested a review from yuxincs August 9, 2026 16:12
@msridhar
msridhar enabled auto-merge (squash) August 9, 2026 16:12
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

MethodInferenceResult was renamed to CallInferenceResult in GenericsChecks.java. The change updates the result interface implementations, the generic-call inference cache, the runInferenceForCall return type, and cached-result lookups used by method-call inference, method-reference inference, and type-argument substitution. Inference behavior remains unchanged.

Possibly related PRs

  • uber/NullAway#1280: Renames the same inference result abstraction and related references.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the rename from MethodInferenceResult to CallInferenceResult.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rename-to-callinferenceresult

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.87%. Comparing base (19779b5) to head (8d99b12).

Additional details and impacted files
@@                       Coverage Diff                       @@
##             update-snapshot-build-script    #1690   +/-   ##
===============================================================
  Coverage                           87.87%   87.87%           
  Complexity                           3167     3167           
===============================================================
  Files                                 109      109           
  Lines                               10739    10739           
  Branches                             2171     2171           
===============================================================
  Hits                                 9437     9437           
  Misses                                617      617           
  Partials                              685      685           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@msridhar
msridhar changed the base branch from master to update-snapshot-build-script August 9, 2026 18:36
@msridhar
msridhar force-pushed the rename-to-callinferenceresult branch from 3d5663b to 8d99b12 Compare August 9, 2026 18:36
@msridhar
msridhar merged commit 69c5630 into update-snapshot-build-script Aug 9, 2026
0 of 10 checks passed
@msridhar
msridhar deleted the rename-to-callinferenceresult branch August 9, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant