Skip to content

Rename MethodInferenceResult to CallInferenceResult - #1692

Open
msridhar wants to merge 1 commit into
masterfrom
MethodInferenceResultrename
Open

Rename MethodInferenceResult to CallInferenceResult#1692
msridhar wants to merge 1 commit into
masterfrom
MethodInferenceResultrename

Conversation

@msridhar

@msridhar msridhar commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Refactoring in preparation for #1544

Summary by CodeRabbit

  • Refactor
    • Updated internal generic-call inference naming for consistency.
    • No user-visible behavior or functionality changes.

@msridhar

msridhar commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator Author

This change is part of the following stack:

Change managed by git-spice.

@msridhar
msridhar requested a review from yuxincs August 9, 2026 18:45
Base automatically changed from update-snapshot-build-script to master August 10, 2026 20:54
@msridhar
msridhar force-pushed the MethodInferenceResultrename branch from 8d99b12 to f54ec86 Compare August 10, 2026 20:54
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4c6be5a2-de49-430d-946a-a71df058dd4e

📥 Commits

Reviewing files that changed from the base of the PR and between 741fbad and f54ec86.

📒 Files selected for processing (1)
  • nullaway/src/main/java/com/uber/nullaway/generics/GenericsChecks.java

Walkthrough

Renames the private MethodInferenceResult interface to CallInferenceResult. Updates InferenceSuccess, InferenceFailure, the generic-call inference cache, inference return types, and cached result lookups. No behavioral logic changes.

Possibly related PRs

  • uber/NullAway#1280: Both changes update the private inference-result abstraction and cache usage in GenericsChecks.java.
  • uber/NullAway#1690: This PR contains the same MethodInferenceResult to CallInferenceResult rename.

Suggested reviewers: yuxincs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: renaming MethodInferenceResult to CallInferenceResult.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch MethodInferenceResultrename

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.87%. Comparing base (7489d69) to head (f54ec86).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1692   +/-   ##
=========================================
  Coverage     87.87%   87.87%           
  Complexity     3167     3167           
=========================================
  Files           109      109           
  Lines         10739    10739           
  Branches       2171     2171           
=========================================
  Hits           9437     9437           
  Misses          617      617           
  Partials        685      685           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@msridhar
msridhar enabled auto-merge (squash) August 10, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant