Skip to content

Add remark-lini-lang to list of plugins - #1500

Closed
monfa-red wants to merge 1 commit into
remarkjs:mainfrom
monfa-red:add-remark-lini-lang
Closed

monfa-red wants to merge 1 commit into
remarkjs:mainfrom
monfa-red:add-remark-lini-lang

Conversation

@monfa-red

Copy link
Copy Markdown

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything or linked relevant results below
  • I made sure the docs are up to date
  • I included tests (or that’s not needed)

Description of changes

Adds remark-lini-lang to the plugin list, after remark-license.

It compiles ```lini code blocks to inline SVG at build time, so it sits in the same spot as remark-mermaidjs but for the Lini diagram language (https://lini.rs). Works with remark().use() and unified 11. It's published as remark-lini-lang because npm wouldn't take remark-lini (too close to remark-lint), which is why the repo name is different. The repo has the remark-plugin topic and keyword.

@github-actions github-actions Bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 24, 2026
@codecov

codecov Bot commented Sep 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (49c74f3) to head (a552f90).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1500   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          138       138           
=========================================
  Hits           138       138           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread doc/plugins.md
compatible)
* 🟢 [`remark-license`](https://github.com/remarkjs/remark-license)
— add a license section
* 🟢 [`remark-lini-lang`](https://github.com/monfa-red/remark-lini)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

  • plugins use default exports, doesn’t look like yours does? https://github.com/monfa-red/remark-lini/blob/main/src/index.ts
  • better to use the same dependencies, e.g., get VFile from vfile and get nodes from mdast, instead of making your own types
  • you also already noted that you are dealing with HTML; that’s great, but that’s a rehype plugin, using hast instead of mdast. This is also why all the similar plugins are rehype plugins, and mentioned in its readme!

@monfa-red

Copy link
Copy Markdown
Author

Thanks for the review! You're right, it outputs HTML, so it should be a rehype plugin. I made rehype-lini and opened rehypejs/rehype#209 to list it there, so I'm closing this one.

remark-lini-lang got the other two fixes as well: it has a default export now and uses the mdast/vfile types.

@monfa-red monfa-red closed this Oct 13, 2026
@github-actions

Copy link
Copy Markdown

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.

@remcohaszing remcohaszing mentioned this pull request Oct 28, 2026
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤞 phase/open Post is being triaged manually

Development

Successfully merging this pull request may close these issues.

2 participants