Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1500 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 138 138
=========================================
Hits 138 138 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wooorm
requested changes
Sep 26, 2026
| compatible) | ||
| * 🟢 [`remark-license`](https://github.com/remarkjs/remark-license) | ||
| — add a license section | ||
| * 🟢 [`remark-lini-lang`](https://github.com/monfa-red/remark-lini) |
Member
There was a problem hiding this comment.
Hi!
- plugins use default exports, doesn’t look like yours does? https://github.com/monfa-red/remark-lini/blob/main/src/index.ts
- better to use the same dependencies, e.g., get
VFilefromvfileand get nodes frommdast, instead of making your own types - you also already noted that you are dealing with HTML; that’s great, but that’s a
rehypeplugin, usinghastinstead ofmdast. This is also why all the similar plugins arerehypeplugins, and mentioned in its readme!
6 tasks done
Author
|
Thanks for the review! You're right, it outputs HTML, so it should be a rehype plugin. I made
|
|
Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the |
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Adds
remark-lini-langto the plugin list, afterremark-license.It compiles
```linicode blocks to inline SVG at build time, so it sits in the same spot asremark-mermaidjsbut for the Lini diagram language (https://lini.rs). Works withremark().use()and unified 11. It's published asremark-lini-langbecause npm wouldn't takeremark-lini(too close toremark-lint), which is why the repo name is different. The repo has theremark-plugintopic and keyword.