Skip to content

Fix infinite loop in plex_connect when handling refreshPlayQueue #3508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anatosun wants to merge 1 commit into from
Closed

Fix infinite loop in plex_connect when handling refreshPlayQueue #3508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions music_assistant/providers/plex_connect/player_remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,6 +857,8 @@ async def handle_refresh_play_queue(self, request: web.Request) -> web.Response:
This is called when the play queue is modified (items added, removed, reordered).
We need to sync the entire updated queue state to MA while preserving playback.
"""
# Set flag to prevent circular updates
self._updating_from_plex = True
try:
play_queue_id = request.query.get("playQueueID")

Expand Down Expand Up @@ -955,6 +957,8 @@ def fetch_queue() -> PlayQueue:
except Exception as e:
LOGGER.exception(f"Error handling refreshPlayQueue: {e}")
return web.Response(status=500, text=str(e))
finally:
self._updating_from_plex = False

async def handle_create_play_queue(self, request: web.Request) -> web.Response:
"""
Expand Down
Loading