Fix infinite loop in plex_connect when handling refreshPlayQueue#3508
Closed
anatosun wants to merge 1 commit intomusic-assistant:devfrom
Closed
Fix infinite loop in plex_connect when handling refreshPlayQueue#3508anatosun wants to merge 1 commit intomusic-assistant:devfrom
anatosun wants to merge 1 commit intomusic-assistant:devfrom
Conversation
handle_refresh_play_queue was missing the _updating_from_plex guard that all other command handlers use. Without it, any queue refresh from Plex would modify the MA queue, triggering _handle_queue_items_updated, which would recreate the Plex PlayQueue, causing another refreshPlayQueue — an infinite loop. The stale PlayQueue 404 errors were also a symptom of this.
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents a circular queue-sync loop between Plex’s refreshPlayQueue callback and Music Assistant’s queue update events by applying the same _updating_from_plex guard used by other Plex command handlers.
Changes:
- Set
self._updating_from_plex = Trueat the start ofhandle_refresh_play_queueprocessing. - Ensure the guard is always cleared via a
finallyblock.
Contributor
Author
|
Closing in favor of #3510 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_refresh_play_queue was missing the _updating_from_plex guard that all other command handlers use. Without it, any queue refresh from Plex would modify the MA queue, triggering _handle_queue_items_updated, which would recreate the Plex PlayQueue, causing another refreshPlayQueue — an infinite loop. The stale PlayQueue 404 errors were also a symptom of this.
It should fix this issue.