fix(FR-2607): align Electron publicPath patch with Vite output

[yomybaby]

Resolves the gap between PR #6871 (Vite spike for es6:// publicPath via
renderBuiltUrl) and PR #6765 / FR-2612 (single React build + post-patch
policy). The post-patch script was still searching for CRA-era /static/...
paths after the Vite migration emitted /assets/..., so make dep produced
an Electron staging dir that referenced root-relative /assets/... that
Electron could not serve via the es6:// scheme handler.

Verification (PR #7113 head, this fix applied)

• bash scripts/verify.sh → Relay / Lint / Format / TypeScript ALL PASS
• make clean && make dep → "Patched 2 file(s). Verification passed: index.html contains es6://assets/"
• make dep run twice → idempotent skip ("Electron app already prepared, skipping")
• pnpm run electron:d → renderer spawns with es6:// scheme registered, login UI renders, all stylesheets load (rule counts > 0), body bg = rgb(247, 247, 246), did-fail-load / webRequest err / 404s = 0
• make mac_arm64 → compile_localproxy + electron-packager (.app) produced cleanly. (DMG step fails on a local NODE_MODULE_VERSION mismatch in a globally-installed electron-installer-dmg; unrelated to this fix and does not affect CI which uses npx.)

Changes

scripts/patch-electron-publicpath.js

• Replace CRA-era patch patterns (/static/js, /static/css, asset-manifest.json, webpack runtime .p='/' rewrites) with Vite-aware patterns.
• Patch index.html: rewrite ="/assets/ → ="es6://assets/ on src/href attributes only.
• Patch CSS files under assets/: url(/assets/...) → url(es6://assets/...) in all quote styles.
• Drop dead Webpack-specific code paths (asset-manifest.json, static/{js,css}, webpack runtime publicPath assignment) that no longer exist in Vite output.
• Update verification marker from es6://static/js/main to es6://assets/.
• Leave <base href="/"> untouched: the renderer loads index.html via file://, and rewriting <base> to es6:// would break window.location/origin alignment (history API, same-origin checks). Webpack-era patch script also did not touch <base>.
• Verification failure now exits non-zero so the Makefile recipe aborts instead of silently continuing.

Makefile

• Update dep_electron idempotency marker from es6://static/js/main to es6://assets/ to match the new patch script.
• Replace ; chaining with && between the dep_electron commands so a failed patch script aborts the recipe.
• Update inline comment that referenced the old marker.

react/vite.config.ts

• Remove the BUILD_TARGET=electron + experimental.renderBuiltUrl branch (PR feat(FR-2607): Vite spike answer — es6:// Electron publicPath works via renderBuiltUrl #6871 spike). FR-2612 mandates a single web build with post-patch; the renderBuiltUrl path would require a second vite build per release and was never wired into the Makefile, making it dead code with regression risk if anyone toggled BUILD_TARGET=electron.
• Drop the now-unused command parameter from defineConfig.

react/package.json

• Remove three unused CRA-era devDependencies: @svgr/webpack (Vite uses vite-plugin-svgr), react-scripts (CRA core, retired in FR-2611), react-dev-utils (no imports anywhere). All three were verified to have zero references in source.

Stack

Sits on top of #7113 (FR-2606 residual build-time warnings).

[yomybaby]

• fix(FR-2529): include backend.ai-client src in craco TS loader and tsconfig paths #6615
• refactor(FR-2529): extract backend.ai-client as standalone workspace package #6614
• fix(FR-2607): align Electron publicPath patch with Vite output #7189 👈 (View in Graphite)
• fix(FR-2606): clear residual build-time warnings (BUI dts + module directive) #7113
• fix(FR-2606): restore Monaco self-hosting in Vite dev server #7104
• feat(FR-2748): fully migrate test files from jest.* to vi.* and align TS globals #7083
• feat(FR-2746): re-enable 5 tests skipped during Vitest migration #7071
• feat(FR-2744): restore Vitest coverage reporting in CI #7065
• fix(FR-2606): replace webpackIgnore with @vite-ignore in dynamic plugin imports #6879
• fix(FR-2606): replace global.packageVersion with globalThis.packageVersion in WebUISider #6878
• fix(FR-2608): disable vite-plugin-pwa auto-manifest to preserve existing manifest.json #6877
• feat(FR-2611): retire Craco/Webpack — build, Makefile, CI all on Vite/Vitest #6876
• feat: migrate BUI + root tests from Jest to Vitest (follow-up to FR-2609) #6875
• feat(FR-2609): Vitest migration for react/ (100% pass, 856/856 tests) #6874
• feat(FR-2608): Vite production build with vite-plugin-pwa service worker #6873
• feat(FR-2610): Vite dev-reload plugin for i18n / theme / config.toml file changes #6872
• feat(FR-2607): Vite spike answer — es6:// Electron publicPath works via renderBuiltUrl #6871
• feat(FR-2606): restore BUI i18n context isolation under Vite dep optimization #6870
• feat(FR-2606): Vite PoC phase 1 — dev server + HMR + React Compiler parity #6869
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• flow:merge-queue - adds this PR to the back of the merge queue
• flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Coverage Report for root-coverage

Status	Category	Percentage	Covered / Total
🔵	Lines	3.78%	85 / 2247
🔵	Statements	4%	92 / 2299
🔵	Functions	3.87%	14 / 361
🔵	Branches	5.12%	68 / 1327

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
scripts/patch-electron-publicpath.js	0%	0%	0%	0%	26-109

Generated in workflow #114 for commit f6c26dc by the Vitest Coverage Report Action

[github-actions]

Coverage Report for react-coverage (./react)

Status	Category	Percentage	Covered / Total
🔵	Lines	6.89%	1781 / 25826
🔵	Statements	5.79%	1976 / 34105
🔵	Functions	5.35%	296 / 5523
🔵	Branches	4.11%	1291 / 31365

File Coverage

No changed files found.

Generated in workflow #114 for commit f6c26dc by the Vitest Coverage Report Action

[Copilot]

Pull request overview

Aligns the Electron staging “publicPath” post-patch flow with Vite’s build output (/assets/...) so Electron can correctly load bundled assets via the custom es6:// scheme without requiring a second, Electron-specific Vite build.

Changes:

• Update the Electron post-patch script to rewrite Vite-style asset references (/assets/...) in index.html and emitted CSS.
• Adjust dep_electron idempotency marker + failure propagation in Makefile to match the new patch behavior.
• Remove the now-dead Electron-only renderBuiltUrl branch from react/vite.config.ts and drop unused CRA-era devDependencies from react/package.json.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
scripts/patch-electron-publicpath.js	Switch patching logic from CRA /static/... to Vite /assets/... and make verification fail fast.
Makefile	Update Electron prep skip-marker and ensure the patch step aborts the recipe on failure.
react/vite.config.ts	Remove unused Electron-specific Vite build branch; rely on single web build + post-patch.
react/package.json	Remove unused CRA-era devDependencies no longer referenced after Vite migration.

[graphite-app]

Merge activity

• Apr 30, 12:12 PM UTC: yomybaby added this pull request to the Graphite merge queue.
• Apr 30, 12:40 PM UTC: Merged by the Graphite merge queue.