fix(FR-2606): replace webpackIgnore with @vite-ignore in dynamic plugin imports by nowgnuesLee · Pull Request #6879 · lablup/backend.ai-webui

nowgnuesLee · 2026-04-22T05:30:05Z

Summary

Dev-server warning spam noticed after the Vite cutover:

[vite] (client) warning:
  .../PluginLoader.tsx:75
    await import(/* webpackIgnore: true */ pluginUrl);
  The above dynamic import cannot be analyzed by Vite.

Two dynamic-import call sites loaded a runtime-computed URL and tagged it with /* webpackIgnore: true */, the CRA/Webpack magic comment that opted out of static analysis. Vite doesn't recognise it, so it defaults to "can't analyse" and warns on every dev rebuild (plus wastes cycles trying to pre-bundle a spec it can't resolve).

Fix: replace /* webpackIgnore: true */ with /* @vite-ignore */ (Vite's equivalent). Runtime behaviour is unchanged — plugins still load fine.

Sites fixed:

react/src/components/PluginLoader.tsx: page-plugin loader for paths under /dist/plugins/*.js
react/src/components/LoginView.tsx: login-plugin loader that pulls from ../../../src/plugins/<name>

Verification

grep -r 'webpackIgnore' react/src → zero value-level hits; only comments that explain the rename
vite:dev no longer warns about un-analysable dynamic imports from these files
Plugin loading still works at runtime

Stack

Top of the stack. This is the final fix bundled from end-to-end verification; reviewing this PR gives a good summary of the whole Vite migration series (the "Stack" section above in the PR lists all 11 PRs in order).

nowgnuesLee · 2026-04-22T05:30:15Z

fix(FR-2529): include backend.ai-client src in craco TS loader and tsconfig paths #6615
refactor(FR-2529): extract backend.ai-client as standalone workspace package #6614
fix(FR-2607): align Electron publicPath patch with Vite output #7189
fix(FR-2606): clear residual build-time warnings (BUI dts + module directive) #7113
fix(FR-2606): restore Monaco self-hosting in Vite dev server #7104
feat(FR-2748): fully migrate test files from jest.* to vi.* and align TS globals #7083
feat(FR-2746): re-enable 5 tests skipped during Vitest migration #7071
feat(FR-2744): restore Vitest coverage reporting in CI #7065
fix(FR-2606): replace webpackIgnore with @vite-ignore in dynamic plugin imports #6879 👈 (View in Graphite)
fix(FR-2606): replace global.packageVersion with globalThis.packageVersion in WebUISider #6878
fix(FR-2608): disable vite-plugin-pwa auto-manifest to preserve existing manifest.json #6877
feat(FR-2611): retire Craco/Webpack — build, Makefile, CI all on Vite/Vitest #6876
feat: migrate BUI + root tests from Jest to Vitest (follow-up to FR-2609) #6875
feat(FR-2609): Vitest migration for react/ (100% pass, 856/856 tests) #6874
feat(FR-2608): Vite production build with vite-plugin-pwa service worker #6873
feat(FR-2610): Vite dev-reload plugin for i18n / theme / config.toml file changes #6872
feat(FR-2607): Vite spike answer — es6:// Electron publicPath works via renderBuiltUrl #6871
feat(FR-2606): restore BUI i18n context isolation under Vite dep optimization #6870
feat(FR-2606): Vite PoC phase 1 — dev server + HMR + React Compiler parity #6869
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

graphite-app · 2026-04-30T12:11:57Z

Merge activity

Apr 30, 12:11 PM UTC: yomybaby added this pull request to the Graphite merge queue.
Apr 30, 12:34 PM UTC: Merged by the Graphite merge queue.

…in imports (#6879) Resolves #6809(FR-2606) ## Summary Dev-server warning spam noticed after the Vite cutover: ``` [vite] (client) warning: .../PluginLoader.tsx:75 await import(/* webpackIgnore: true */ pluginUrl); The above dynamic import cannot be analyzed by Vite. ``` Two dynamic-import call sites loaded a runtime-computed URL and tagged it with `/* webpackIgnore: true */`, the CRA/Webpack magic comment that opted out of static analysis. Vite doesn't recognise it, so it defaults to "can't analyse" and warns on every dev rebuild (plus wastes cycles trying to pre-bundle a spec it can't resolve). **Fix**: replace `/* webpackIgnore: true */` with `/* @vite-ignore */` (Vite's equivalent). Runtime behaviour is unchanged — plugins still load fine. **Sites fixed**: - `react/src/components/PluginLoader.tsx`: page-plugin loader for paths under `/dist/plugins/*.js` - `react/src/components/LoginView.tsx`: login-plugin loader that pulls from `../../../src/plugins/<name>` ## Verification - [x] `grep -r 'webpackIgnore' react/src` → zero value-level hits; only comments that explain the rename - [x] `vite:dev` no longer warns about un-analysable dynamic imports from these files - [x] Plugin loading still works at runtime ## Stack Top of the stack. This is the final fix bundled from end-to-end verification; reviewing this PR gives a good summary of the whole Vite migration series (the "Stack" section above in the PR lists all 11 PRs in order).

Resolves #7064(FR-2744) ## Summary FR-2611 dropped `ArtiomTr/jest-coverage-report-action` (Jest-only) when CI moved to Vitest, so PRs lost the coverage diff comment and inline test-failure annotations. This restores the equivalent surface using `davelosert/vitest-coverage-report-action@v2`. ### Local setup - Add `@vitest/coverage-v8@^4.1.4` as devDependency in `react/`, `packages/backend.ai-ui/`, root. - Coverage block in each `vitest.config.ts`: - `provider: 'v8'` — uses Node's V8 inspector, no Babel transform needed (fastest provider). - `reporter: ['text', 'json', 'json-summary', 'html']` — `json-summary` is what the GitHub Action consumes; `text` keeps a console summary; `html` lets devs open `coverage/index.html` locally. - `exclude` patterns trim test files, stories, generated Relay artifacts, and zero-logic entries (`src/index.tsx`, `reportWebVitals`, BUI locale catalog, `wsproxy`, bundled `backend.ai-client-node.*`). - `/coverage` added to `packages/backend.ai-ui/.gitignore` (root and react/ already had it). ### CI setup - `.github/workflows/vitest.yml` gains `pull-requests: write` permission so the action can post / update its PR comment. - Each of the three jobs (`react-vitest`, `backend-ai-ui-vitest`, `root-vitest`) runs `pnpm exec vitest run --coverage` and follows it with a `davelosert/vitest-coverage-report-action@v2` step keyed by a unique `name:` so the three PR comments don't collide. - The action runs with `if: always()` so a coverage comment posts even when tests fail (matches the prior Jest behaviour, which surfaced failed-test annotations). ## Verification ``` === react/ === Lines 7.23% (1645/22722) === BUI === Lines 7.91% (317/4006) === root === Lines 3.66% (282/7703) ``` - [x] All three workspaces produce `coverage/coverage-summary.json` in the shape the action expects - [x] Test pass counts unchanged (react 856/856, BUI 315 + 5 skip, root 90 + 1 skip) - [x] No regression in lint / format ## Out of scope - **No coverage threshold gates** — baseline %s above are intentionally low (mostly UI code without unit tests). Gating now would block normal PRs. A separate decision on thresholds belongs to a follow-up after the team agrees on a target. - README coverage badge. - Backfilling the 6 `TODO(FR-2609)` skipped tests. ## Stack Top of the Vite migration stack (now 12 PRs). Builds on PR #6879 (`fix(FR-2606)` webpackIgnore → @vite-ignore).

github-actions Bot assigned nowgnuesLee Apr 22, 2026

github-actions Bot added the size:S 10~30 LoC label Apr 22, 2026

nowgnuesLee force-pushed the 04-21-fix_fr-2606_replace_global.packageversion_with_globalthis.packageversion_in_webuisider branch from ac2e78d to 4afa90d Compare April 27, 2026 13:57

nowgnuesLee force-pushed the 04-21-fix_fr-2606_replace_webpackignore_with_vite-ignore_in_dynamic_plugin_imports branch from 2b59a1b to 4147197 Compare April 27, 2026 13:57

This was referenced Apr 27, 2026

fix(FR-2606): restore Monaco self-hosting in Vite dev server #7104

Merged

fix(FR-2606): clear residual build-time warnings (BUI dts + module directive) #7113

Merged

nowgnuesLee marked this pull request as ready for review April 28, 2026 04:25

Copilot AI review requested due to automatic review settings April 28, 2026 04:25

nowgnuesLee force-pushed the 04-21-fix_fr-2606_replace_webpackignore_with_vite-ignore_in_dynamic_plugin_imports branch 2 times, most recently from f3317ab to 91d8e0d Compare April 28, 2026 05:15

nowgnuesLee force-pushed the 04-21-fix_fr-2606_replace_global.packageversion_with_globalthis.packageversion_in_webuisider branch from 47b0844 to 71a5bf7 Compare April 28, 2026 05:19

nowgnuesLee force-pushed the 04-21-fix_fr-2606_replace_webpackignore_with_vite-ignore_in_dynamic_plugin_imports branch from 91d8e0d to 7223909 Compare April 28, 2026 05:19

nowgnuesLee force-pushed the 04-21-fix_fr-2606_replace_global.packageversion_with_globalthis.packageversion_in_webuisider branch from 71a5bf7 to fa7e95d Compare April 28, 2026 05:25

nowgnuesLee force-pushed the 04-21-fix_fr-2606_replace_webpackignore_with_vite-ignore_in_dynamic_plugin_imports branch from 7223909 to ac5909d Compare April 28, 2026 05:25

nowgnuesLee force-pushed the 04-21-fix_fr-2606_replace_global.packageversion_with_globalthis.packageversion_in_webuisider branch from fa7e95d to 5f1405f Compare April 28, 2026 05:28

nowgnuesLee force-pushed the 04-21-fix_fr-2606_replace_webpackignore_with_vite-ignore_in_dynamic_plugin_imports branch from ac5909d to 0d2caed Compare April 28, 2026 05:28

yomybaby mentioned this pull request Apr 30, 2026

fix(FR-2607): align Electron publicPath patch with Vite output #7189

Merged

yomybaby force-pushed the 04-21-fix_fr-2606_replace_global.packageversion_with_globalthis.packageversion_in_webuisider branch from 5f1405f to cdc4e8a Compare April 30, 2026 12:08

yomybaby force-pushed the 04-21-fix_fr-2606_replace_webpackignore_with_vite-ignore_in_dynamic_plugin_imports branch from 0d2caed to a4205c8 Compare April 30, 2026 12:08

This was referenced Apr 30, 2026

refactor(FR-2529): extract backend.ai-client as standalone workspace package #6614

Merged

fix(FR-2529): include backend.ai-client src in craco TS loader and tsconfig paths #6615

Closed

graphite-app Bot force-pushed the 04-21-fix_fr-2606_replace_global.packageversion_with_globalthis.packageversion_in_webuisider branch from cdc4e8a to 6683df9 Compare April 30, 2026 12:17

graphite-app Bot force-pushed the 04-21-fix_fr-2606_replace_webpackignore_with_vite-ignore_in_dynamic_plugin_imports branch from a4205c8 to c303197 Compare April 30, 2026 12:18

Base automatically changed from 04-21-fix_fr-2606_replace_global.packageversion_with_globalthis.packageversion_in_webuisider to main April 30, 2026 12:33

graphite-app Bot merged commit c303197 into main Apr 30, 2026
7 of 8 checks passed

graphite-app Bot deleted the 04-21-fix_fr-2606_replace_webpackignore_with_vite-ignore_in_dynamic_plugin_imports branch April 30, 2026 12:34

github-pages Bot temporarily deployed to github-pages April 30, 2026 12:35 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(FR-2606): replace webpackIgnore with @vite-ignore in dynamic plugin imports#6879

fix(FR-2606): replace webpackIgnore with @vite-ignore in dynamic plugin imports#6879
graphite-app[bot] merged 1 commit intomainfrom
04-21-fix_fr-2606_replace_webpackignore_with_vite-ignore_in_dynamic_plugin_imports

nowgnuesLee commented Apr 22, 2026 •

edited

Loading

Uh oh!

nowgnuesLee commented Apr 22, 2026 •

edited

Loading

Uh oh!

graphite-app Bot commented Apr 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

nowgnuesLee commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Stack

Uh oh!

nowgnuesLee commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

graphite-app Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

nowgnuesLee commented Apr 22, 2026 •

edited

Loading

nowgnuesLee commented Apr 22, 2026 •

edited

Loading

graphite-app Bot commented Apr 30, 2026 •

edited

Loading