fix(FR-2608): disable vite-plugin-pwa auto-manifest to preserve existing manifest.json by nowgnuesLee · Pull Request #6877 · lablup/backend.ai-webui

nowgnuesLee · 2026-04-22T05:30:02Z

Summary

Follow-up fix for FR-2608. Discovered while verifying the end-to-end production build in FR-2611.

Bug: vite-plugin-pwa generates a manifest.webmanifest from react/package.json metadata and auto-injects <link rel="manifest" href="/manifest.webmanifest"> into index.html. That competes with the repo's own manifest.json (already copied into build/web/ by copyresource) — the auto one has:

wrong name: "backend-ai-webui-react" (react package name, not product)
wrong theme_color: "#42b883" (Vue green, pulled from some default)
no icons

Whichever manifest the browser picks first can leave PWA installs with bogus metadata.

Fix: one-line manifest: false option in the VitePWA plugin config. The plugin now only emits the service worker and leaves manifest handling to the existing copyresource pipeline.

Verification

pnpm run build produces only build/web/manifest.json (the real one); no manifest.webmanifest
Built index.html references only href="manifest.json"

Stack

Sits above FR-2611; logically resolves an issue introduced in FR-2608 but couldn't be amended there without invasive rebase.

nowgnuesLee · 2026-04-22T05:30:14Z

fix(FR-2529): include backend.ai-client src in craco TS loader and tsconfig paths #6615
refactor(FR-2529): extract backend.ai-client as standalone workspace package #6614
fix(FR-2607): align Electron publicPath patch with Vite output #7189
fix(FR-2606): clear residual build-time warnings (BUI dts + module directive) #7113
fix(FR-2606): restore Monaco self-hosting in Vite dev server #7104
feat(FR-2748): fully migrate test files from jest.* to vi.* and align TS globals #7083
feat(FR-2746): re-enable 5 tests skipped during Vitest migration #7071
feat(FR-2744): restore Vitest coverage reporting in CI #7065
fix(FR-2606): replace webpackIgnore with @vite-ignore in dynamic plugin imports #6879
fix(FR-2606): replace global.packageVersion with globalThis.packageVersion in WebUISider #6878
fix(FR-2608): disable vite-plugin-pwa auto-manifest to preserve existing manifest.json #6877 👈 (View in Graphite)
feat(FR-2611): retire Craco/Webpack — build, Makefile, CI all on Vite/Vitest #6876
feat: migrate BUI + root tests from Jest to Vitest (follow-up to FR-2609) #6875
feat(FR-2609): Vitest migration for react/ (100% pass, 856/856 tests) #6874
feat(FR-2608): Vite production build with vite-plugin-pwa service worker #6873
feat(FR-2610): Vite dev-reload plugin for i18n / theme / config.toml file changes #6872
feat(FR-2607): Vite spike answer — es6:// Electron publicPath works via renderBuiltUrl #6871
feat(FR-2606): restore BUI i18n context isolation under Vite dep optimization #6870
feat(FR-2606): Vite PoC phase 1 — dev server + HMR + React Compiler parity #6869
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

Disables vite-plugin-pwa’s auto-generated web manifest so the app continues to use the repo’s authoritative manifest.json (copied into build/web/ by the existing build pipeline), preventing conflicting PWA metadata in production builds.

Changes:

Disable PWA plugin manifest generation/injection by setting manifest: false.
Add inline documentation explaining why manifest generation must remain disabled.

graphite-app · 2026-04-30T12:11:54Z

Merge activity

Apr 30, 12:11 PM UTC: yomybaby added this pull request to the Graphite merge queue.
Apr 30, 12:32 PM UTC: Merged by the Graphite merge queue.

…ing manifest.json (#6877) Resolves #6811(FR-2608) ## Summary Follow-up fix for FR-2608. Discovered while verifying the end-to-end production build in FR-2611. **Bug**: `vite-plugin-pwa` generates a `manifest.webmanifest` from `react/package.json` metadata and auto-injects `<link rel="manifest" href="/manifest.webmanifest">` into `index.html`. That competes with the repo's own `manifest.json` (already copied into `build/web/` by `copyresource`) — the auto one has: - wrong `name`: `"backend-ai-webui-react"` (react package name, not product) - wrong `theme_color`: `"#42b883"` (Vue green, pulled from some default) - **no icons** Whichever manifest the browser picks first can leave PWA installs with bogus metadata. **Fix**: one-line `manifest: false` option in the VitePWA plugin config. The plugin now only emits the service worker and leaves manifest handling to the existing `copyresource` pipeline. ## Verification - [x] `pnpm run build` produces only `build/web/manifest.json` (the real one); no `manifest.webmanifest` - [x] Built `index.html` references only `href="manifest.json"` ## Stack Sits above FR-2611; logically resolves an issue introduced in FR-2608 but couldn't be amended there without invasive rebase.

…ker (#6873) Resolves #6811(FR-2608) ## Summary Production build via Vite + `vite-plugin-pwa` service worker. This is the point where `vite build` produces a complete deployable `build/` directory. **Build output** (new layout): - `build/index.html` — built from project-root `index.html` via the `transformIndexHtml` hook - `build/assets/*.js` — hashed chunks (Vite default) - `build/sw.js` — service worker generated by `vite-plugin-pwa` (generateSW strategy) - `build/workbox-*.js` — workbox runtime **PWA plugin options** mirror the craco-era `workbox-webpack-plugin` GenerateSW call (`craco.config.cjs:390-400`): - `strategies: 'generateSW'` + `filename: 'sw.js'` - `injectRegister: false` — the existing registration script in `index.html:126-131` stays in charge (preserves legacy behaviour; we do not opt into `registerType: 'autoUpdate'`). - `skipWaiting: true`, `clientsClaim: true` - `maximumFileSizeToCacheInBytes: 5 MiB` - `globIgnores: ['**/*.map', '**/asset-manifest.json']` ## Test plan - [x] `pnpm run vite:build` completes without errors - [x] `build/sw.js` generated, precaches ~460 entries (~22 MB) - [x] SW registration path in `index.html` still resolves ## Follow-up (PR #6877) The plugin also emits `manifest.webmanifest` by default, which competes with the repo's own `manifest.json`. That's disabled in the follow-up `fix(FR-2608)` PR further up the stack. ## Stack Builds on FR-2610.

github-actions Bot assigned nowgnuesLee Apr 22, 2026

github-actions Bot added the size:XS ~10 LoC label Apr 22, 2026

nowgnuesLee force-pushed the 04-21-fix_fr-2608_disable_vite-plugin-pwa_auto-manifest_to_preserve_existing_manifest.json branch from ef57101 to 78236e1 Compare April 27, 2026 13:57

This was referenced Apr 27, 2026

fix(FR-2606): restore Monaco self-hosting in Vite dev server #7104

Merged

fix(FR-2606): clear residual build-time warnings (BUI dts + module directive) #7113

Merged

nowgnuesLee marked this pull request as ready for review April 28, 2026 04:25

Copilot AI review requested due to automatic review settings April 28, 2026 04:25

Copilot started reviewing on behalf of nowgnuesLee April 28, 2026 04:26 View session

Copilot AI reviewed Apr 28, 2026

View reviewed changes

nowgnuesLee force-pushed the 04-21-fix_fr-2608_disable_vite-plugin-pwa_auto-manifest_to_preserve_existing_manifest.json branch from 78236e1 to b789f9e Compare April 28, 2026 05:02

nowgnuesLee force-pushed the 04-21-feat_fr-2611_retire_craco_webpack_build_makefile_ci_all_on_vite_vitest branch 2 times, most recently from 560dea4 to 7372c48 Compare April 28, 2026 05:15

nowgnuesLee force-pushed the 04-21-fix_fr-2608_disable_vite-plugin-pwa_auto-manifest_to_preserve_existing_manifest.json branch from b789f9e to 3aa344c Compare April 28, 2026 05:15

nowgnuesLee force-pushed the 04-21-feat_fr-2611_retire_craco_webpack_build_makefile_ci_all_on_vite_vitest branch from 7372c48 to a68b158 Compare April 28, 2026 05:19

nowgnuesLee force-pushed the 04-21-fix_fr-2608_disable_vite-plugin-pwa_auto-manifest_to_preserve_existing_manifest.json branch from 3aa344c to 9750f0b Compare April 28, 2026 05:19

nowgnuesLee force-pushed the 04-21-feat_fr-2611_retire_craco_webpack_build_makefile_ci_all_on_vite_vitest branch from a68b158 to ff24662 Compare April 28, 2026 05:25

nowgnuesLee force-pushed the 04-21-fix_fr-2608_disable_vite-plugin-pwa_auto-manifest_to_preserve_existing_manifest.json branch from 9750f0b to 4b6a570 Compare April 28, 2026 05:25

nowgnuesLee force-pushed the 04-21-feat_fr-2611_retire_craco_webpack_build_makefile_ci_all_on_vite_vitest branch from ff24662 to ed450f5 Compare April 28, 2026 05:28

nowgnuesLee force-pushed the 04-21-fix_fr-2608_disable_vite-plugin-pwa_auto-manifest_to_preserve_existing_manifest.json branch from 4b6a570 to 0bd7009 Compare April 28, 2026 05:28

yomybaby mentioned this pull request Apr 30, 2026

fix(FR-2607): align Electron publicPath patch with Vite output #7189

Merged

yomybaby force-pushed the 04-21-fix_fr-2608_disable_vite-plugin-pwa_auto-manifest_to_preserve_existing_manifest.json branch from 0bd7009 to 7253345 Compare April 30, 2026 12:08

yomybaby force-pushed the 04-21-feat_fr-2611_retire_craco_webpack_build_makefile_ci_all_on_vite_vitest branch from ed450f5 to 07e96d8 Compare April 30, 2026 12:08

This was referenced Apr 30, 2026

refactor(FR-2529): extract backend.ai-client as standalone workspace package #6614

Merged

fix(FR-2529): include backend.ai-client src in craco TS loader and tsconfig paths #6615

Closed

graphite-app Bot force-pushed the 04-21-feat_fr-2611_retire_craco_webpack_build_makefile_ci_all_on_vite_vitest branch from 07e96d8 to eaec713 Compare April 30, 2026 12:16

graphite-app Bot force-pushed the 04-21-fix_fr-2608_disable_vite-plugin-pwa_auto-manifest_to_preserve_existing_manifest.json branch from 7253345 to 7b13055 Compare April 30, 2026 12:17

Base automatically changed from 04-21-feat_fr-2611_retire_craco_webpack_build_makefile_ci_all_on_vite_vitest to main April 30, 2026 12:31

graphite-app Bot merged commit 7b13055 into main Apr 30, 2026
4 checks passed

graphite-app Bot deleted the 04-21-fix_fr-2608_disable_vite-plugin-pwa_auto-manifest_to_preserve_existing_manifest.json branch April 30, 2026 12:32

github-pages Bot temporarily deployed to github-pages April 30, 2026 12:33 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(FR-2608): disable vite-plugin-pwa auto-manifest to preserve existing manifest.json#6877

fix(FR-2608): disable vite-plugin-pwa auto-manifest to preserve existing manifest.json#6877
graphite-app[bot] merged 1 commit intomainfrom
04-21-fix_fr-2608_disable_vite-plugin-pwa_auto-manifest_to_preserve_existing_manifest.json

nowgnuesLee commented Apr 22, 2026 •

edited

Loading

Uh oh!

nowgnuesLee commented Apr 22, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

graphite-app Bot commented Apr 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nowgnuesLee commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Stack

Uh oh!

nowgnuesLee commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

graphite-app Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nowgnuesLee commented Apr 22, 2026 •

edited

Loading

nowgnuesLee commented Apr 22, 2026 •

edited

Loading

graphite-app Bot commented Apr 30, 2026 •

edited

Loading