docs(FR-2542): update date selection UI in statistics documentation#6580
Conversation
nowgnuesLee
left a comment
There was a problem hiding this comment.
Review: PR #6580 — docs: update date selection UI in statistics documentation
Summary
The PR updates the "Select Period" dropdown reference to "date range picker" in the User Session History section across all 4 languages. Additionally, the JA and TH files received a welcome cleanup — translating previously untranslated English text into their respective languages. Changes are accurate and consistent.
Findings
[en/statistics/statistics.md]
i18n Completeness [Nice to Have]: The Allocation History section (line 7) still references "select period menu." If this section's UI also changed to a date range picker, it should be updated too. If it's a different UI control, then it's fine as-is. Could you please confirm?
[ja/statistics/statistics.md]
Good improvements beyond the date picker change:
- Section headings properly translated ("Allocation history" -> "割り当て履歴", "User session history" -> "ユーザーセッション履歴")
- "Fractional GPU" -> "フラクショナルGPU" now matches TERMINOLOGY.md
- All bullet items fully translated from English to Japanese
- Trailing newline added (fixes missing newline at EOF)
No issues found.
[ko/statistics/statistics.md]
Clean change. Also fixed the missing space in "통계페이지" -> "통계 페이지". Good catch.
No issues found.
[th/statistics/statistics.md]
Good improvements:
- Section headings properly translated ("Allocation history" -> "ประวัติการจัดสรร", "User session history" -> "ประวัติเซสชันผู้ใช้")
- "GPU แบบเศษส่วน" matches TERMINOLOGY.md
- Punctuation cleanup (removed stray Japanese periods that were mixed into Thai text)
- Trailing newline added
No issues found.
Recommendation
LGTM. All 4 languages are updated consistently, translations are accurate and follow the terminology guide, and the JA/TH cleanup is a welcome improvement. The only open question is whether the Allocation History section in EN should also be updated (depends on whether that section's UI also changed).
c3b5021 to
af4738c
Compare
1143c51 to
4595e4a
Compare
af4738c to
ae270c1
Compare
4595e4a to
dfb9cbd
Compare
ae270c1 to
50eb61e
Compare
dfb9cbd to
0a4de8a
Compare
50eb61e to
e08caf3
Compare
e08caf3 to
db94d35
Compare
0a4de8a to
afd6699
Compare
afd6699 to
1d03617
Compare
310f85b to
2001b34
Compare
2001b34 to
6308a70
Compare
53b4277 to
1dcd862
Compare
1dcd862 to
e73d492
Compare
6308a70 to
cea06be
Compare
e73d492 to
c5a025a
Compare
b39f701 to
c04a4cd
Compare
c5a025a to
bb6c856
Compare
bb6c856 to
e6fe622
Compare
Merge activity
|
…6580) Resolves #6686 (FR-2542) ## Summary - Update Statistics page documentation to describe the **Period** dropdown (Daily/Weekly/Monthly) and date range picker - Add details on how to select a custom date range using the calendar-based date picker - Clarify that the statistics data updates based on the selected period and date range - Apply reviewer fixes for accuracy and i18n consistency across all 4 languages ## Changes - `statistics/statistics.md` (en/ko/ja/th): Period dropdown description, date range picker details, updated usage workflow ## Test plan - [ ] Verify Period dropdown options (Daily/Weekly/Monthly) match the actual Statistics UI - [ ] Verify date range picker behavior description is accurate 🤖 Generated with [Claude Code](https://claude.com/claude-code)
8d665dc to
bde839e
Compare
e6fe622 to
d8adac8
Compare

Resolves #6686 (FR-2542)
Summary
Changes
statistics/statistics.md(en/ko/ja/th): Period dropdown description, date range picker details, updated usage workflowTest plan
🤖 Generated with Claude Code