Skip to content

docs(FR-2542): update date selection UI in statistics documentation#6580

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-10-docs_update_date_selection_ui_in_statistics_documentation
Apr 17, 2026
Merged

docs(FR-2542): update date selection UI in statistics documentation#6580
graphite-app[bot] merged 1 commit intomainfrom
04-10-docs_update_date_selection_ui_in_statistics_documentation

Conversation

@nowgnuesLee
Copy link
Copy Markdown
Contributor

@nowgnuesLee nowgnuesLee commented Apr 10, 2026

Resolves #6686 (FR-2542)

Summary

  • Update Statistics page documentation to describe the Period dropdown (Daily/Weekly/Monthly) and date range picker
  • Add details on how to select a custom date range using the calendar-based date picker
  • Clarify that the statistics data updates based on the selected period and date range
  • Apply reviewer fixes for accuracy and i18n consistency across all 4 languages

Changes

  • statistics/statistics.md (en/ko/ja/th): Period dropdown description, date range picker details, updated usage workflow

Test plan

  • Verify Period dropdown options (Daily/Weekly/Monthly) match the actual Statistics UI
  • Verify date range picker behavior description is accurate

🤖 Generated with Claude Code

Copy link
Copy Markdown
Contributor Author

nowgnuesLee commented Apr 10, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor Author

@nowgnuesLee nowgnuesLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: PR #6580 — docs: update date selection UI in statistics documentation

Summary

The PR updates the "Select Period" dropdown reference to "date range picker" in the User Session History section across all 4 languages. Additionally, the JA and TH files received a welcome cleanup — translating previously untranslated English text into their respective languages. Changes are accurate and consistent.

Findings

[en/statistics/statistics.md]

i18n Completeness [Nice to Have]: The Allocation History section (line 7) still references "select period menu." If this section's UI also changed to a date range picker, it should be updated too. If it's a different UI control, then it's fine as-is. Could you please confirm?

[ja/statistics/statistics.md]

Good improvements beyond the date picker change:

  • Section headings properly translated ("Allocation history" -> "割り当て履歴", "User session history" -> "ユーザーセッション履歴")
  • "Fractional GPU" -> "フラクショナルGPU" now matches TERMINOLOGY.md
  • All bullet items fully translated from English to Japanese
  • Trailing newline added (fixes missing newline at EOF)

No issues found.

[ko/statistics/statistics.md]

Clean change. Also fixed the missing space in "통계페이지" -> "통계 페이지". Good catch.

No issues found.

[th/statistics/statistics.md]

Good improvements:

  • Section headings properly translated ("Allocation history" -> "ประวัติการจัดสรร", "User session history" -> "ประวัติเซสชันผู้ใช้")
  • "GPU แบบเศษส่วน" matches TERMINOLOGY.md
  • Punctuation cleanup (removed stray Japanese periods that were mixed into Thai text)
  • Trailing newline added

No issues found.

Recommendation

LGTM. All 4 languages are updated consistently, translations are accurate and follow the terminology guide, and the JA/TH cleanup is a welcome improvement. The only open question is whether the Allocation History section in EN should also be updated (depends on whether that section's UI also changed).

@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_date_selection_ui_in_statistics_documentation branch from c3b5021 to af4738c Compare April 10, 2026 02:20
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch 2 times, most recently from 1143c51 to 4595e4a Compare April 10, 2026 09:25
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_date_selection_ui_in_statistics_documentation branch from af4738c to ae270c1 Compare April 10, 2026 09:26
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch from 4595e4a to dfb9cbd Compare April 10, 2026 09:33
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_date_selection_ui_in_statistics_documentation branch from ae270c1 to 50eb61e Compare April 10, 2026 09:33
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch from dfb9cbd to 0a4de8a Compare April 11, 2026 03:46
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_date_selection_ui_in_statistics_documentation branch from 50eb61e to e08caf3 Compare April 11, 2026 03:46
@github-actions github-actions Bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Apr 11, 2026
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_date_selection_ui_in_statistics_documentation branch from e08caf3 to db94d35 Compare April 12, 2026 14:16
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch from 0a4de8a to afd6699 Compare April 12, 2026 14:16
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch from afd6699 to 1d03617 Compare April 13, 2026 08:04
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch from 310f85b to 2001b34 Compare April 14, 2026 05:45
@nowgnuesLee nowgnuesLee changed the title docs: update date selection UI in statistics documentation docs(FR-2542): update date selection UI in statistics documentation Apr 14, 2026
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch from 2001b34 to 6308a70 Compare April 15, 2026 07:08
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_date_selection_ui_in_statistics_documentation branch from 53b4277 to 1dcd862 Compare April 15, 2026 07:08
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_date_selection_ui_in_statistics_documentation branch from 1dcd862 to e73d492 Compare April 15, 2026 07:38
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch from 6308a70 to cea06be Compare April 15, 2026 07:38
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_date_selection_ui_in_statistics_documentation branch from e73d492 to c5a025a Compare April 15, 2026 09:19
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch 2 times, most recently from b39f701 to c04a4cd Compare April 16, 2026 09:36
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_date_selection_ui_in_statistics_documentation branch from c5a025a to bb6c856 Compare April 16, 2026 09:36
@agatha197 agatha197 force-pushed the 04-10-docs_update_date_selection_ui_in_statistics_documentation branch from bb6c856 to e6fe622 Compare April 16, 2026 14:47
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 17, 2026

Merge activity

…6580)

Resolves #6686 (FR-2542)

## Summary

- Update Statistics page documentation to describe the **Period** dropdown (Daily/Weekly/Monthly) and date range picker
- Add details on how to select a custom date range using the calendar-based date picker
- Clarify that the statistics data updates based on the selected period and date range
- Apply reviewer fixes for accuracy and i18n consistency across all 4 languages

## Changes

- `statistics/statistics.md` (en/ko/ja/th): Period dropdown description, date range picker details, updated usage workflow

## Test plan

- [ ] Verify Period dropdown options (Daily/Weekly/Monthly) match the actual Statistics UI
- [ ] Verify date range picker behavior description is accurate

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@graphite-app graphite-app Bot force-pushed the 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation branch from 8d665dc to bde839e Compare April 17, 2026 10:59
@graphite-app graphite-app Bot force-pushed the 04-10-docs_update_date_selection_ui_in_statistics_documentation branch from e6fe622 to d8adac8 Compare April 17, 2026 10:59
Base automatically changed from 04-10-docs_fix_permission_label_formatting_in_vfolder_documentation to main April 17, 2026 11:03
@graphite-app graphite-app Bot merged commit d8adac8 into main Apr 17, 2026
4 checks passed
@graphite-app graphite-app Bot deleted the 04-10-docs_update_date_selection_ui_in_statistics_documentation branch April 17, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Update date selection UI in statistics documentation (FR-2542)

3 participants