Skip to content

docs(FR-2533): update user_settings with new settings and remove obsolete ones#6571

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones
Apr 17, 2026
Merged

docs(FR-2533): update user_settings with new settings and remove obsolete ones#6571
graphite-app[bot] merged 1 commit intomainfrom
04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones

Conversation

@nowgnuesLee
Copy link
Copy Markdown
Contributor

@nowgnuesLee nowgnuesLee commented Apr 10, 2026

Resolves #6677 (FR-2533)

Summary

  • Update language selector documentation with full list of 20 supported languages and searchable dropdown behavior
  • Document the new AI Agents experimental feature in User Settings
  • Add a note about keypair information dialog showing a table view with extended management options
  • Fix import_run button labels to match current UI text

Changes

  • user_settings/user_settings.md (en/ko/ja/th): language selector details, AI Agents experimental feature, keypair note
  • import_run/import_run.md (en/ko/ja/th): corrected button label references

Test plan

  • Verify language list (20 languages) matches the actual UI
  • Verify AI Agents toggle is visible under Experimental Features
  • Verify keypair dialog note is accurate

🤖 Generated with Claude Code

Copy link
Copy Markdown
Contributor Author

nowgnuesLee commented Apr 10, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor Author

@nowgnuesLee nowgnuesLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: PR #6571 — docs: update user_settings with new settings and remove obsolete ones

Summary

Good documentation cleanup: adds Theme Mode, Keep Login Session Information, Max Concurrent Uploads; removes obsolete Classic UI switch; translates previously-untranslated sections in JA and TH (which had raw English text mixed in). The overall quality and i18n label matching is solid. A few minor issues noted below.

Findings

[File: src/ja/user_settings/user_settings.md]

i18n Completeness [Nice to Have]: The checkbox label 変更のみ表示 in the doc does not match the actual i18n label in ja.json, which is "ShowOnlyChanged": "表示のみの変更". Please verify which one users actually see in the UI and align the doc accordingly.

[File: src/en/user_settings/user_settings.md]

i18n Completeness [Nice to Have]: The heading ### Keep Login Session Information omits "while Logout" from the actual UI label ("KeepLoginSessionInformation": "Keep Login Session Information while Logout" in en.json). The body text covers the semantics, but for consistency with the UI, consider using the full label as the heading. Same applies to the other 3 languages (they do match their respective i18n labels, so this is EN-only).

General (all files)

Code Hygiene [Nice to Have]: The PR description still has the template placeholders (resolves #NNN (FR-MMM)). Please update with actual issue numbers or remove if not applicable.

Correctness [Positive]: Previously untranslated sections in JA and TH (e.g., notes, descriptions that were left in English) are now fully translated. The old JA/TH docs had issues like "Enables デスクトップ通知s" and "Experimental 機能s" which are now correctly translated.

i18n Completeness [Positive]: Section headings and bold UI labels across all 4 languages consistently match their respective resources/i18n/{lang}.json values (Theme Mode, Desktop Notification, Compact Sidebar, Auto Logout, My Keypair Info, SSH Keypair Management, Max Concurrent Uploads, Bootstrap Script, User Config Script, Experimental Features). Well done.

Style Guide Compliance [Positive]: Heading levels (H1 > H2 > H3) are correct. Title Case used for EN headings. Admonitions use :::note syntax. Blank lines around images and headings are consistent. Second-person voice used throughout.

Recommendation

LGTM — The content is accurate, all 4 languages are structurally aligned, and i18n labels are verified. The two minor label mismatches noted above are nice-to-haves and do not block merge.

@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_incorrect_permission_labels_in_share_vfolder_documentation branch from 9595fa1 to 81a65dc Compare April 10, 2026 09:25
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch from 7d08cb3 to 0f0a17f Compare April 10, 2026 09:25
@github-actions github-actions Bot added size:L 100~500 LoC and removed size:XL 500~ LoC labels Apr 10, 2026
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch from 0f0a17f to bbd0558 Compare April 11, 2026 03:46
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_incorrect_permission_labels_in_share_vfolder_documentation branch from 86cc8fc to 43e5370 Compare April 12, 2026 14:16
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch from bbd0558 to 5fc8537 Compare April 12, 2026 14:16
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_incorrect_permission_labels_in_share_vfolder_documentation branch from 43e5370 to ad15443 Compare April 13, 2026 08:04
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch from 5fc8537 to 0a124c0 Compare April 13, 2026 08:04
@nowgnuesLee nowgnuesLee marked this pull request as ready for review April 13, 2026 11:56
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_incorrect_permission_labels_in_share_vfolder_documentation branch from fadfba7 to 52e5cce Compare April 15, 2026 07:08
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch from f114a55 to 4b6d722 Compare April 15, 2026 07:08
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_incorrect_permission_labels_in_share_vfolder_documentation branch from 52e5cce to eee6449 Compare April 15, 2026 07:38
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch from 4b6d722 to 8e13af1 Compare April 15, 2026 07:38
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_incorrect_permission_labels_in_share_vfolder_documentation branch from eee6449 to ed4a9bc Compare April 15, 2026 09:19
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch 2 times, most recently from 64248cc to c78b6fe Compare April 16, 2026 09:36
@agatha197 agatha197 force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch from c78b6fe to dfa849a Compare April 16, 2026 14:47
@yomybaby yomybaby force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch from dfa849a to 7e07be2 Compare April 17, 2026 08:43
@yomybaby yomybaby requested a review from agatha197 April 17, 2026 08:43
@yomybaby yomybaby force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch from 7e07be2 to dfa849a Compare April 17, 2026 08:43
@yomybaby yomybaby force-pushed the 04-10-docs_fix_incorrect_permission_labels_in_share_vfolder_documentation branch from 846941e to 28fc36b Compare April 17, 2026 08:43
yomybaby added a commit that referenced this pull request Apr 17, 2026
This reverts commit d3ca954.

#6575 was merged with base=main because `gt track --parent main` on a locally untracked branch caused Graphite to record main as its parent. The subsequent `gt submit --publish --force` pushed this base change to GitHub, and the PR was then squash merged, collapsing 29 commits from 6 stacked PRs into a single commit on main:

- #6570 docs(FR-2532): share_vfolder labels
- #6571 docs(FR-2533): user_settings
- #6572 docs(FR-2534): 2FA/TOTP/SSO login
- #6573 docs(FR-2535): header session timer & menu
- #6574 docs(FR-2536): Start From URL & announcement banner
- #6575 docs(FR-2537): dashboard board customization & auto-refresh

Reverting so each PR can be merged in its original stack order.

After this revert merges:
- #6575 will be reopened with its original base (#6574's branch)
- #6625's base will be restored to #6611's branch
- The other open PRs (#6570, #6571, #6572, #6573, #6574) retain their original bases and will be mergeable in stack order
@graphite-app graphite-app Bot changed the base branch from 04-10-docs_fix_incorrect_permission_labels_in_share_vfolder_documentation to graphite-base/6571 April 17, 2026 09:52
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 17, 2026

Merge activity

@graphite-app graphite-app Bot changed the base branch from graphite-base/6571 to main April 17, 2026 09:55
@yomybaby yomybaby force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch from dfa849a to e9f9e1d Compare April 17, 2026 10:10
…lete ones (#6571)

Resolves #6677 (FR-2533)

## Summary

- Update language selector documentation with full list of 20 supported languages and searchable dropdown behavior
- Document the new **AI Agents** experimental feature in User Settings
- Add a note about keypair information dialog showing a table view with extended management options
- Fix import_run button labels to match current UI text

## Changes

- `user_settings/user_settings.md` (en/ko/ja/th): language selector details, AI Agents experimental feature, keypair note
- `import_run/import_run.md` (en/ko/ja/th): corrected button label references

## Test plan

- [ ] Verify language list (20 languages) matches the actual UI
- [ ] Verify AI Agents toggle is visible under Experimental Features
- [ ] Verify keypair dialog note is accurate

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@graphite-app graphite-app Bot force-pushed the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch from e9f9e1d to 573292d Compare April 17, 2026 10:11
@graphite-app graphite-app Bot merged commit 573292d into main Apr 17, 2026
8 checks passed
@graphite-app graphite-app Bot deleted the 04-10-docs_update_user_settings_with_new_settings_and_remove_obsolete_ones branch April 17, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Update user_settings with new settings and remove obsolete ones (FR-2533)

4 participants