docs(FR-2533): update user_settings with new settings and remove obsolete ones#6571
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
nowgnuesLee
left a comment
There was a problem hiding this comment.
Review: PR #6571 — docs: update user_settings with new settings and remove obsolete ones
Summary
Good documentation cleanup: adds Theme Mode, Keep Login Session Information, Max Concurrent Uploads; removes obsolete Classic UI switch; translates previously-untranslated sections in JA and TH (which had raw English text mixed in). The overall quality and i18n label matching is solid. A few minor issues noted below.
Findings
[File: src/ja/user_settings/user_settings.md]
i18n Completeness [Nice to Have]: The checkbox label 変更のみ表示 in the doc does not match the actual i18n label in ja.json, which is "ShowOnlyChanged": "表示のみの変更". Please verify which one users actually see in the UI and align the doc accordingly.
[File: src/en/user_settings/user_settings.md]
i18n Completeness [Nice to Have]: The heading ### Keep Login Session Information omits "while Logout" from the actual UI label ("KeepLoginSessionInformation": "Keep Login Session Information while Logout" in en.json). The body text covers the semantics, but for consistency with the UI, consider using the full label as the heading. Same applies to the other 3 languages (they do match their respective i18n labels, so this is EN-only).
General (all files)
Code Hygiene [Nice to Have]: The PR description still has the template placeholders (resolves #NNN (FR-MMM)). Please update with actual issue numbers or remove if not applicable.
Correctness [Positive]: Previously untranslated sections in JA and TH (e.g., notes, descriptions that were left in English) are now fully translated. The old JA/TH docs had issues like "Enables デスクトップ通知s" and "Experimental 機能s" which are now correctly translated.
i18n Completeness [Positive]: Section headings and bold UI labels across all 4 languages consistently match their respective resources/i18n/{lang}.json values (Theme Mode, Desktop Notification, Compact Sidebar, Auto Logout, My Keypair Info, SSH Keypair Management, Max Concurrent Uploads, Bootstrap Script, User Config Script, Experimental Features). Well done.
Style Guide Compliance [Positive]: Heading levels (H1 > H2 > H3) are correct. Title Case used for EN headings. Admonitions use :::note syntax. Blank lines around images and headings are consistent. Second-person voice used throughout.
Recommendation
LGTM — The content is accurate, all 4 languages are structurally aligned, and i18n labels are verified. The two minor label mismatches noted above are nice-to-haves and do not block merge.
9595fa1 to
81a65dc
Compare
7d08cb3 to
0f0a17f
Compare
0f0a17f to
bbd0558
Compare
86cc8fc to
43e5370
Compare
bbd0558 to
5fc8537
Compare
43e5370 to
ad15443
Compare
5fc8537 to
0a124c0
Compare
fadfba7 to
52e5cce
Compare
f114a55 to
4b6d722
Compare
52e5cce to
eee6449
Compare
4b6d722 to
8e13af1
Compare
eee6449 to
ed4a9bc
Compare
64248cc to
c78b6fe
Compare
c78b6fe to
dfa849a
Compare
dfa849a to
7e07be2
Compare
7e07be2 to
dfa849a
Compare
846941e to
28fc36b
Compare
This reverts commit d3ca954. #6575 was merged with base=main because `gt track --parent main` on a locally untracked branch caused Graphite to record main as its parent. The subsequent `gt submit --publish --force` pushed this base change to GitHub, and the PR was then squash merged, collapsing 29 commits from 6 stacked PRs into a single commit on main: - #6570 docs(FR-2532): share_vfolder labels - #6571 docs(FR-2533): user_settings - #6572 docs(FR-2534): 2FA/TOTP/SSO login - #6573 docs(FR-2535): header session timer & menu - #6574 docs(FR-2536): Start From URL & announcement banner - #6575 docs(FR-2537): dashboard board customization & auto-refresh Reverting so each PR can be merged in its original stack order. After this revert merges: - #6575 will be reopened with its original base (#6574's branch) - #6625's base will be restored to #6611's branch - The other open PRs (#6570, #6571, #6572, #6573, #6574) retain their original bases and will be mergeable in stack order
Merge activity
|
dfa849a to
e9f9e1d
Compare
…lete ones (#6571) Resolves #6677 (FR-2533) ## Summary - Update language selector documentation with full list of 20 supported languages and searchable dropdown behavior - Document the new **AI Agents** experimental feature in User Settings - Add a note about keypair information dialog showing a table view with extended management options - Fix import_run button labels to match current UI text ## Changes - `user_settings/user_settings.md` (en/ko/ja/th): language selector details, AI Agents experimental feature, keypair note - `import_run/import_run.md` (en/ko/ja/th): corrected button label references ## Test plan - [ ] Verify language list (20 languages) matches the actual UI - [ ] Verify AI Agents toggle is visible under Experimental Features - [ ] Verify keypair dialog note is accurate 🤖 Generated with [Claude Code](https://claude.com/claude-code)
e9f9e1d to
573292d
Compare

Resolves #6677 (FR-2533)
Summary
Changes
user_settings/user_settings.md(en/ko/ja/th): language selector details, AI Agents experimental feature, keypair noteimport_run/import_run.md(en/ko/ja/th): corrected button label referencesTest plan
🤖 Generated with Claude Code