Skip to content

docs(FR-2539): update copy button location in my_environments documentation#6577

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-10-docs_update_copy_button_location_in_my_environments_documentation
Apr 17, 2026
Merged

docs(FR-2539): update copy button location in my_environments documentation#6577
graphite-app[bot] merged 1 commit intomainfrom
04-10-docs_update_copy_button_location_in_my_environments_documentation

Conversation

@nowgnuesLee
Copy link
Copy Markdown
Contributor

@nowgnuesLee nowgnuesLee commented Apr 10, 2026

Resolves #6683 (FR-2539)

Summary

  • Update My Environments documentation to reflect the current table columns (added Runtime, Created Date columns)
  • Document the search and filter functionality and the Refresh button
  • Fix the copy button location description (moved from end of row to image name cell)
  • Apply reviewer fixes

Changes

  • my_environments/my_environments.md (en/ko/ja/th): current table columns, search/filter, refresh button, corrected copy button location

Test plan

  • Verify table column list matches the current My Environments page
  • Verify copy button location description is accurate

🤖 Generated with Claude Code

Copy link
Copy Markdown
Contributor Author

nowgnuesLee commented Apr 10, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor Author

@nowgnuesLee nowgnuesLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: PR #6577 — docs: update copy button location in my_environments documentation

Summary

This PR updates the copy button location description across all 4 languages (en/ja/ko/th) to reflect the UI change from a control column button to an inline copy icon on the image name cell. The PR also fixes previously untranslated English text in the JA and TH intro paragraphs, which is a welcome improvement.

Findings

[All files: en/ja/ko/th my_environments.md]

i18n Completeness — Should Fix: The column name "Full Image Path" is used as-is (English, Title Case) across all 4 languages. Per the Documentation Style Guide and Translation Guide, UI labels in documentation should match the actual i18n translations from resources/i18n/{lang}.json. The actual labels are:

Language Docs (current) i18n file (FullImagePath key)
EN Full Image Path Full image path
JA Full Image Path ベースイメージ名
KO Full Image Path 전체 이미지 경로
TH Full Image Path เส้นทางภาพเต็ม

For EN, it is minor (capitalization only). For JA/KO/TH, the column name should be localized to match what users actually see in the UI. Could you please update?

[File: ja/my_environments/my_environments.md]

Correctness — Nice to Have: The JA i18n label ベースイメージ名 translates to "Base image name", which is semantically different from "Full image path". This may indicate the JA i18n file itself has an incorrect translation for this key, or the column was renamed at some point. It would be good to verify whether the JA UI actually shows ベースイメージ名 or Full image path for this column, and align accordingly.

Recommendation

Approve with suggestions — The content changes are accurate and match the current UI screenshot. The translation of previously untranslated JA/TH intro paragraphs is a good catch. The column name localization is the main suggestion to improve consistency with the actual UI.

@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_button_labels_in_import_run_documentation branch from d82f724 to ce673af Compare April 10, 2026 09:25
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch 2 times, most recently from cb80247 to a2ccc83 Compare April 10, 2026 09:33
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_button_labels_in_import_run_documentation branch from ce41fa8 to 6660e5a Compare April 11, 2026 03:46
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch from a2ccc83 to 6520e17 Compare April 11, 2026 03:46
@github-actions github-actions Bot added size:L 100~500 LoC and removed size:S 10~30 LoC labels Apr 11, 2026
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch from 6520e17 to 934d9a9 Compare April 12, 2026 14:16
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_button_labels_in_import_run_documentation branch from 6660e5a to 109e3cc Compare April 12, 2026 14:16
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_button_labels_in_import_run_documentation branch from 109e3cc to cdeb258 Compare April 13, 2026 08:04
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch from 934d9a9 to a69110a Compare April 13, 2026 08:04
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch from 14026d1 to 945764f Compare April 15, 2026 07:08
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_button_labels_in_import_run_documentation branch from df8f65e to 8310e72 Compare April 15, 2026 07:38
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch from 945764f to 378e887 Compare April 15, 2026 07:38
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_button_labels_in_import_run_documentation branch from 8310e72 to 5fe6509 Compare April 15, 2026 09:19
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch from 378e887 to 3b20c1e Compare April 15, 2026 09:19
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_fix_button_labels_in_import_run_documentation branch from 5fe6509 to 436894c Compare April 16, 2026 09:36
@nowgnuesLee nowgnuesLee force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch from 3b20c1e to 8528fd6 Compare April 16, 2026 09:36
@agatha197 agatha197 force-pushed the 04-10-docs_fix_button_labels_in_import_run_documentation branch from 436894c to f664fda Compare April 16, 2026 14:47
@agatha197 agatha197 force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch from 8528fd6 to 7be42e6 Compare April 16, 2026 14:47
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 17, 2026

Merge activity

@yomybaby yomybaby changed the base branch from 04-10-docs_fix_button_labels_in_import_run_documentation to graphite-base/6577 April 17, 2026 10:55
…tation (#6577)

Resolves #6683 (FR-2539)

## Summary

- Update My Environments documentation to reflect the current table columns (added Runtime, Created Date columns)
- Document the search and filter functionality and the **Refresh** button
- Fix the copy button location description (moved from end of row to image name cell)
- Apply reviewer fixes

## Changes

- `my_environments/my_environments.md` (en/ko/ja/th): current table columns, search/filter, refresh button, corrected copy button location

## Test plan

- [ ] Verify table column list matches the current My Environments page
- [ ] Verify copy button location description is accurate

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@graphite-app graphite-app Bot force-pushed the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch from 7be42e6 to db98be4 Compare April 17, 2026 10:57
@github-actions github-actions Bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Apr 17, 2026
@graphite-app graphite-app Bot changed the base branch from graphite-base/6577 to 04-10-docs_fix_button_labels_in_import_run_documentation April 17, 2026 10:58
Base automatically changed from 04-10-docs_fix_button_labels_in_import_run_documentation to main April 17, 2026 11:00
@graphite-app graphite-app Bot merged commit db98be4 into main Apr 17, 2026
4 checks passed
@graphite-app graphite-app Bot deleted the 04-10-docs_update_copy_button_location_in_my_environments_documentation branch April 17, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500~ LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Update copy button location in my_environments documentation (FR-2539)

2 participants