Skip to content

Optimize meshlet material pipeline preparation #23794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CrazyRoka wants to merge 1 commit into
base: main
Choose a base branch
from
+155 −149
Open

Optimize meshlet material pipeline preparation #23794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
304 changes: 155 additions & 149 deletions crates/bevy_pbr/src/meshlet/material_pipeline_prepare.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ use bevy_platform::collections::{HashMap, HashSet};
use bevy_render::erased_render_asset::ErasedRenderAssets;
use bevy_render::{camera::TemporalJitter, render_resource::*, view::ExtractedView};
use bevy_utils::default;
use core::any::{Any, TypeId};
use core::any::TypeId;

/// A list of `(Material ID, Pipeline, BindGroup)` for a view for use in [`meshlet_main_opaque_pass`](`super::meshlet_main_opaque_pass`).
#[derive(Component, Deref, DerefMut, Default)]
Expand Down Expand Up @@ -165,79 +165,84 @@ pub fn prepare_material_meshlet_meshes_main_opaque_pass(
continue;
}

let erased_key = ErasedMaterialPipelineKey {
mesh_key: ErasedMeshPipelineKey::new(view_key),
material_key: material.properties.material_key.clone(),
type_id: material_id.type_id(),
};
let material_pipeline_specializer = MaterialPipelineSpecializer {
pipeline: material_pipeline.clone(),
properties: material.properties.clone(),
};
let Ok(material_pipeline_descriptor) =
material_pipeline_specializer.specialize(erased_key, fake_vertex_buffer_layout)
else {
continue;
};
let material_fragment = material_pipeline_descriptor.fragment.unwrap();

let mut shader_defs = material_fragment.shader_defs;
shader_defs.push("MESHLET_MESH_MATERIAL_PASS".into());

let layout = mesh_pipeline.get_view_layout(view_key.into());
let layout = vec![
layout.main_layout.clone(),
layout.binding_array_layout.clone(),
resource_manager.material_shade_bind_group_layout.clone(),
material
.properties
.material_layout
.as_ref()
.unwrap()
.clone(),
];

let pipeline_descriptor = RenderPipelineDescriptor {
label: material_pipeline_descriptor.label,
layout,
immediate_size: 0,
vertex: VertexState {
shader: meshlet_pipelines.meshlet_mesh_material.clone(),
shader_defs: shader_defs.clone(),
entry_point: material_pipeline_descriptor.vertex.entry_point,
buffers: Vec::new(),
},
primitive: PrimitiveState::default(),
depth_stencil: Some(DepthStencilState {
format: TextureFormat::Depth16Unorm,
depth_write_enabled: Some(false),
depth_compare: Some(CompareFunction::Equal),
stencil: StencilState::default(),
bias: DepthBiasState::default(),
}),
multisample: MultisampleState::default(),
fragment: Some(FragmentState {
shader: match material.properties.get_shader(MeshletFragmentShader) {
Some(shader) => shader.clone(),
None => meshlet_pipelines.meshlet_mesh_material.clone(),
},
shader_defs,
entry_point: material_fragment.entry_point,
targets: material_fragment.targets,
}),
zero_initialize_workgroup_memory: false,
};
let type_id = material_id.type_id();
let Some(material_bind_group_allocator) = material_bind_group_allocators.get(&type_id)
else {
continue;
};
let material_id = instance_manager.get_material_id(material_id);

let pipeline_id = *cache.entry((view_key, type_id)).or_insert_with(|| {
pipeline_cache.queue_render_pipeline(pipeline_descriptor.clone())
});
let pipeline_id = if let Some(&id) = cache.get(&(view_key, type_id)) {
id
} else {
let erased_key = ErasedMaterialPipelineKey {
mesh_key: ErasedMeshPipelineKey::new(view_key),
material_key: material.properties.material_key.clone(),
type_id,
};
let material_pipeline_specializer = MaterialPipelineSpecializer {
pipeline: material_pipeline.clone(),
properties: material.properties.clone(),
};
let Ok(material_pipeline_descriptor) =
material_pipeline_specializer.specialize(erased_key, fake_vertex_buffer_layout)
else {
continue;
};
let material_fragment = material_pipeline_descriptor.fragment.unwrap();

let mut shader_defs = material_fragment.shader_defs;
shader_defs.push("MESHLET_MESH_MATERIAL_PASS".into());

let layout = mesh_pipeline.get_view_layout(view_key.into());
let layout = vec![
layout.main_layout.clone(),
layout.binding_array_layout.clone(),
resource_manager.material_shade_bind_group_layout.clone(),
material
.properties
.material_layout
.as_ref()
.unwrap()
.clone(),
];

let pipeline_descriptor = RenderPipelineDescriptor {
label: material_pipeline_descriptor.label,
layout,
immediate_size: 0,
vertex: VertexState {
shader: meshlet_pipelines.meshlet_mesh_material.clone(),
shader_defs: shader_defs.clone(),
entry_point: material_pipeline_descriptor.vertex.entry_point,
buffers: Vec::new(),
},
primitive: PrimitiveState::default(),
depth_stencil: Some(DepthStencilState {
format: TextureFormat::Depth16Unorm,
depth_write_enabled: Some(false),
depth_compare: Some(CompareFunction::Equal),
stencil: StencilState::default(),
bias: DepthBiasState::default(),
}),
multisample: MultisampleState::default(),
fragment: Some(FragmentState {
shader: match material.properties.get_shader(MeshletFragmentShader) {
Some(shader) => shader.clone(),
None => meshlet_pipelines.meshlet_mesh_material.clone(),
},
shader_defs,
entry_point: material_fragment.entry_point,
targets: material_fragment.targets,
}),
zero_initialize_workgroup_memory: false,
};

let pipeline_id = pipeline_cache.queue_render_pipeline(pipeline_descriptor);
cache.insert((view_key, type_id), pipeline_id);
pipeline_id
};

let material_id = instance_manager.get_material_id(material_id);
let Some(material_bind_group) =
material_bind_group_allocator.get(material.binding.group)
else {
Expand Down Expand Up @@ -318,8 +323,8 @@ pub fn prepare_material_meshlet_meshes_prepass(
let Some(material) = render_materials.get(material_id) else {
continue;
};
let Some(material_bind_group_allocator) =
material_bind_group_allocators.get(&material_id.type_id())
let type_id = material_id.type_id();
let Some(material_bind_group_allocator) = material_bind_group_allocators.get(&type_id)
else {
continue;
};
Expand All @@ -340,93 +345,94 @@ pub fn prepare_material_meshlet_meshes_prepass(
continue;
}

let erased_key = ErasedMaterialPipelineKey {
mesh_key: ErasedMeshPipelineKey::new(view_key),
material_key: material.properties.material_key.clone(),
type_id: material_id.type_id(),
};
let material_pipeline_specializer = PrepassPipelineSpecializer {
pipeline: prepass_pipeline.clone(),
properties: material.properties.clone(),
};
let Ok(material_pipeline_descriptor) =
material_pipeline_specializer.specialize(erased_key, fake_vertex_buffer_layout)
else {
continue;
};
let material_fragment = material_pipeline_descriptor.fragment.unwrap();

let mut shader_defs = material_fragment.shader_defs;
shader_defs.push("MESHLET_MESH_MATERIAL_PASS".into());

let view_layout = if view_key.contains(MeshPipelineKey::MOTION_VECTOR_PREPASS) {
prepass_pipeline.view_layout_motion_vectors.clone()
} else {
prepass_pipeline.view_layout_no_motion_vectors.clone()
};

let fragment_shader = if view_key.contains(MeshPipelineKey::DEFERRED_PREPASS) {
material
.properties
.get_shader(MeshletDeferredFragmentShader)
.unwrap_or(meshlet_pipelines.meshlet_mesh_material.clone())
} else {
material
.properties
.get_shader(MeshletPrepassFragmentShader)
.unwrap_or(meshlet_pipelines.meshlet_mesh_material.clone())
};

let entry_point = if fragment_shader == meshlet_pipelines.meshlet_mesh_material {
material_fragment.entry_point.clone()
let pipeline_id = if let Some(&id) = cache.get(&(view_key, type_id)) {
id
} else {
None
};

let pipeline_descriptor = RenderPipelineDescriptor {
label: material_pipeline_descriptor.label,
layout: vec![
view_layout,
prepass_pipeline.empty_layout.clone(),
resource_manager.material_shade_bind_group_layout.clone(),
let erased_key = ErasedMaterialPipelineKey {
mesh_key: ErasedMeshPipelineKey::new(view_key),
material_key: material.properties.material_key.clone(),
type_id,
};
let material_pipeline_specializer = PrepassPipelineSpecializer {
pipeline: prepass_pipeline.clone(),
properties: material.properties.clone(),
};
let Ok(material_pipeline_descriptor) =
material_pipeline_specializer.specialize(erased_key, fake_vertex_buffer_layout)
else {
continue;
};
let material_fragment = material_pipeline_descriptor.fragment.unwrap();

let mut shader_defs = material_fragment.shader_defs;
shader_defs.push("MESHLET_MESH_MATERIAL_PASS".into());

let view_layout = if view_key.contains(MeshPipelineKey::MOTION_VECTOR_PREPASS) {
prepass_pipeline.view_layout_motion_vectors.clone()
} else {
prepass_pipeline.view_layout_no_motion_vectors.clone()
};

let fragment_shader = if view_key.contains(MeshPipelineKey::DEFERRED_PREPASS) {
material
.properties
.material_layout
.as_ref()
.unwrap()
.clone(),
],
vertex: VertexState {
shader: meshlet_pipelines.meshlet_mesh_material.clone(),
shader_defs: shader_defs.clone(),
entry_point: material_pipeline_descriptor.vertex.entry_point,
.get_shader(MeshletDeferredFragmentShader)
.unwrap_or(meshlet_pipelines.meshlet_mesh_material.clone())
} else {
material
.properties
.get_shader(MeshletPrepassFragmentShader)
.unwrap_or(meshlet_pipelines.meshlet_mesh_material.clone())
};

let entry_point = if fragment_shader == meshlet_pipelines.meshlet_mesh_material {
material_fragment.entry_point.clone()
} else {
None
};

let pipeline_descriptor = RenderPipelineDescriptor {
label: material_pipeline_descriptor.label,
layout: vec![
view_layout,
prepass_pipeline.empty_layout.clone(),
resource_manager.material_shade_bind_group_layout.clone(),
material
.properties
.material_layout
.as_ref()
.unwrap()
.clone(),
],
vertex: VertexState {
shader: meshlet_pipelines.meshlet_mesh_material.clone(),
shader_defs: shader_defs.clone(),
entry_point: material_pipeline_descriptor.vertex.entry_point,
..default()
},
primitive: PrimitiveState::default(),
depth_stencil: Some(DepthStencilState {
format: TextureFormat::Depth16Unorm,
depth_write_enabled: Some(false),
depth_compare: Some(CompareFunction::Equal),
stencil: StencilState::default(),
bias: DepthBiasState::default(),
}),
fragment: Some(FragmentState {
shader: fragment_shader,
shader_defs,
entry_point,
targets: material_fragment.targets,
}),
..default()
},
primitive: PrimitiveState::default(),
depth_stencil: Some(DepthStencilState {
format: TextureFormat::Depth16Unorm,
depth_write_enabled: Some(false),
depth_compare: Some(CompareFunction::Equal),
stencil: StencilState::default(),
bias: DepthBiasState::default(),
}),
fragment: Some(FragmentState {
shader: fragment_shader,
shader_defs,
entry_point,
targets: material_fragment.targets,
}),
..default()
};

let pipeline_id = pipeline_cache.queue_render_pipeline(pipeline_descriptor);
cache.insert((view_key, type_id), pipeline_id);
pipeline_id
};

let material_id = instance_manager.get_material_id(material_id);

let pipeline_id = *cache
.entry((view_key, material_id.type_id()))
.or_insert_with(|| {
pipeline_cache.queue_render_pipeline(pipeline_descriptor.clone())
});

let Some(material_bind_group) =
material_bind_group_allocator.get(material.binding.group)
else {
Expand Down