Optimize meshlet material pipeline preparation#23794
Open
CrazyRoka wants to merge 1 commit intobevyengine:mainfrom
Open
Optimize meshlet material pipeline preparation#23794CrazyRoka wants to merge 1 commit intobevyengine:mainfrom
CrazyRoka wants to merge 1 commit intobevyengine:mainfrom
Conversation
14fae7b to
7f65740
Compare
JMS55
approved these changes
Apr 14, 2026
Contributor
|
Thanks for the PR! Noting for future reference: The real fix will be to make this retained on each entity, similiar to how the standard Bevy renderer was restructured a few releases ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
prepare_material_meshlet_meshes_main_opaque_passandprepare_material_meshlet_meshes_prepassperformance during the render preparation phase.Solution
The previous implementation performed expensive computations for every meshlet instance before checking if the resulting
pipeline_idwas already in thecache.I refactored the caching logic to check the cache beforehand. The heavy computation is now wrapped inside the cache-miss block.
Testing
unique-materialsflag is enabled:cargo run --features=meshlet,https --release --example many_meshlet_materials -- --unique-materials3d/meshletexample behavior before and after the fix.Showcase
Before - 52% CPU usage (Flamegraph)
After - 6.7% CPU usage (Flamegraph)