Skip to content

MWPW-191681 add KE and MU to Express locales#766

Merged
afmicka merged 11 commits intomainfrom
MWPW-191681
Apr 23, 2026
Merged

MWPW-191681 add KE and MU to Express locales#766
afmicka merged 11 commits intomainfrom
MWPW-191681

Conversation

@yesil
Copy link
Copy Markdown
Contributor

@yesil yesil commented Apr 15, 2026

Resolves https://jira.corp.adobe.com/browse/MWPW-191681
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

ℹ️ Created corresponding tags on Odin QA and Odin Prod as well.

image

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

🧪 Nala E2E Tests

Nala tests run automatically when you open this PR.

To run Nala tests again:

  1. Add the run nala label to this PR (in the right sidebar)
  2. Tests will run automatically on the current commit
  3. Any future commits will also trigger tests as long as the label remains

To stop automatic Nala tests:

  • Remove the run nala label

Note: Tests only run on commits if the run nala label is present. Add the label whenever you need tests to run on new changes.

Test URLs:

yesil and others added 2 commits April 15, 2026 13:02
@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Apr 15, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.33%. Comparing base (c28811b) to head (b04634c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
- Coverage   87.41%   87.33%   -0.09%     
==========================================
  Files         210      210              
  Lines       62870    62870              
==========================================
- Hits        54960    54907      -53     
- Misses       7910     7963      +53     

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c28811b...b04634c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yesil yesil requested review from 3ch023, honstar and npeltier April 15, 2026 12:44
@honstar
Copy link
Copy Markdown
Contributor

honstar commented Apr 15, 2026

One thing: can you also add the new tags to odin stage as well just to have it complete across environments?

@yesil
Copy link
Copy Markdown
Contributor Author

yesil commented Apr 15, 2026

@honstar the other tags are not created on stage neither, so I skipped it

@honstar
Copy link
Copy Markdown
Contributor

honstar commented Apr 15, 2026

@honstar the other tags are not created on stage neither, so I skipped it

No problem, we'll probably clean up and resync stage with prod at some point anyway.

@afmicka afmicka added the RCP-restricted Pull request should not be merged during RCP label Apr 22, 2026
@afmicka afmicka removed the RCP-restricted Pull request should not be merged during RCP label Apr 23, 2026
@afmicka afmicka merged commit 78fbf5f into main Apr 23, 2026
14 of 16 checks passed
@afmicka afmicka deleted the MWPW-191681 branch April 23, 2026 09:17
pinata-agent Bot pushed a commit to adobecom/mas-pinata that referenced this pull request Apr 27, 2026
Add unit tests that assert Kenya (KE) and Mauritius (MU) exist in
COUNTRY_DATA and in the EXPRESS surface's en_US regions array, and
that they resolve correctly via getDefaultLocaleCode / getSurfaceLocales.
Confirms the data-only change landed by MWPW-191681 / PR adobecom#766.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants