Skip to content

MWPW-193416: add MU country as a region of en_US#780

Merged
3ch023 merged 2 commits intomainfrom
MWPW-193211
Apr 23, 2026
Merged

MWPW-193416: add MU country as a region of en_US#780
3ch023 merged 2 commits intomainfrom
MWPW-193211

Conversation

@3ch023
Copy link
Copy Markdown
Contributor

@3ch023 3ch023 commented Apr 22, 2026

Resolves https://jira.corp.adobe.com/browse/MWPW-193416
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

Test URLs:

Milo pages

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Apr 22, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@yesil
Copy link
Copy Markdown
Contributor

yesil commented Apr 22, 2026

@3ch023 #766 is already doing the same.

@afmicka
Copy link
Copy Markdown
Contributor

afmicka commented Apr 22, 2026

@yesil yours is adding it for Express. This one is for Acom

@afmicka afmicka added run nala RCP-restricted Pull request should not be merged during RCP labels Apr 22, 2026
'TH',
'VN',
'ZA',
'MU',
Copy link
Copy Markdown
Contributor

@afmicka afmicka Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3ch023 should we add this in the alphabetical order? Or you want to keep it at the bottom on purpose?

@afmicka afmicka removed the RCP-restricted Pull request should not be merged during RCP label Apr 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.32%. Comparing base (d313931) to head (9222a9e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #780   +/-   ##
=======================================
  Coverage   87.32%   87.32%           
=======================================
  Files         210      210           
  Lines       62870    62870           
=======================================
  Hits        54904    54904           
  Misses       7966     7966           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d313931...9222a9e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@3ch023 3ch023 merged commit a25ffda into main Apr 23, 2026
13 checks passed
@3ch023 3ch023 deleted the MWPW-193211 branch April 23, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants