Skip to content

test(io): add locales tests for KE and MU on Express surface#307

Closed
pinata-agent[bot] wants to merge 2 commits intomainfrom
MWPW-191681
Closed

test(io): add locales tests for KE and MU on Express surface#307
pinata-agent[bot] wants to merge 2 commits intomainfrom
MWPW-191681

Conversation

@pinata-agent
Copy link
Copy Markdown

@pinata-agent pinata-agent Bot commented Apr 27, 2026

Summary

  • Add regression tests asserting KE and MU locales remain part of the Express surface locale list
  • Kenya (KE) and Mauritius (MU) are already present in io/www/src/fragment/locales.js — this PR adds test coverage to prevent silent removal

Issue

Closes #306

Test plan

  • just health passes for all services
  • just test passes
  • Manual smoke test of changed functionality

Test URLs:


🪅 Piñata Implementation

Issue: #306 feat: Add KE and MU locales to Express surface
Spec: 📦 View implementation spec

Summary
Kenya (KE) and Mauritius (MU) are already wired into the Express surface in io/www/src/fragment/locales.js (merged in PR adobecom#766, commit 78fbf5f, on the same Jira ticket MWPW-191681). No source change is required. To close out the issue cleanly, add a small regression test that asserts both regions remain part of the Express en_US family so a future cleanup cannot silently drop them.

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Apr 27, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Apr 27, 2026

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Comment thread io/www/test/fragment/locales.test.js
@pinata-agent
Copy link
Copy Markdown
Author

pinata-agent Bot commented Apr 27, 2026

🪅 Piñata Code Review

Verdict: ✅ Approve

Severity Count Files
🔴 Critical 0
🟠 Major 0
🔵 Nit 1 io/www/test/fragment/locales.test.js

Key Findings

  • Asymmetric test coverage: tests 3 and 4 guard KE exclusion from non-Express surfaces but omit the equivalent check for MU — non-blocking, but worth fixing for symmetry.

Notes

This PR adds pure regression tests for existing functionality (KE and MU already wired into Express in PR adobecom#766). No production code changed. The core coverage — both locales present on Express, resolving to en_US, correct country names and flags — is correct and well-structured.

The file path (io/www/test/fragment/locales.test.js) falls outside the nala/ test tree; Nala E2E expertise does not directly apply, but the test quality principles (symmetric coverage, clear intent per test case) are universal.

📖 Domains: mas-nala

Reviewed 1 file across 1 domain · 1 finding · pinata-agent

Comment thread nala/studio/express/locales/tests/express_locales.test.js
@pinata-agent
Copy link
Copy Markdown
Author

pinata-agent Bot commented Apr 27, 2026

🪅 Piñata Code Review

Verdict: ✅ Approve

Severity Count Files
🔴 Critical 0
🟠 Major 0
🔵 Nit 1 nala/studio/express/locales/tests/express_locales.test.js

Key Findings

  • Missing .page.js in the new express/locales/ directory — the repeated page.evaluate(import(...)) calls could be extracted into a page-helper class to align with the three-file pattern (non-blocking).

Incremental review: 1 new finding on latest push (2 files changed). 1 previous finding on io/www/test/fragment/locales.test.js — please verify (nit, non-blocking).

📖 Domains: mas-nala

Reviewed 2 files across 1 domain · 1 finding · pinata-agent

@antonio-rmrz antonio-rmrz deleted the MWPW-191681 branch April 27, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add KE and MU locales to Express surface

1 participant