Skip to content

Mqtt frames v6#8508

Closed
hsadia538 wants to merge 3 commits into
OISF:masterfrom
hsadia538:mqtt-frames-v6
Closed

Mqtt frames v6#8508
hsadia538 wants to merge 3 commits into
OISF:masterfrom
hsadia538:mqtt-frames-v6

Conversation

@hsadia538
Copy link
Copy Markdown
Contributor

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5731

Previous PR: #8507

Describe new changes:

  • Fix commits

suricata-verify-pr: 1065

Adds PDU, Header and Data frame to the MQTT parser.
Ticket: 5731
@hsadia538 hsadia538 requested a review from jasonish as a code owner February 2, 2023 01:55
@hsadia538 hsadia538 mentioned this pull request Feb 2, 2023
3 tasks
@hsadia538
Copy link
Copy Markdown
Contributor Author

hsadia538 commented Feb 2, 2023

I see check Rust CI failure but its fixing a lot of files that are unrelated to my PR. It is because of the release?

there is a portion for mqtt.rs but when I run the command I don't get anything for mqtt files.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 2, 2023

Codecov Report

Merging #8508 (06aa97f) into master (d9e6301) will increase coverage by 0.15%.
The diff coverage is 86.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8508      +/-   ##
==========================================
+ Coverage   81.84%   81.99%   +0.15%     
==========================================
  Files         967      967              
  Lines      278343   278424      +81     
==========================================
+ Hits       227799   228292     +493     
+ Misses      50544    50132     -412     
Flag Coverage Δ
fuzzcorpus 64.16% <84.44%> (+0.22%) ⬆️
suricata-verify 59.91% <85.55%> (+0.25%) ⬆️
unittests 63.33% <3.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@hsadia538 hsadia538 mentioned this pull request Feb 2, 2023
3 tasks
@victorjulien
Copy link
Copy Markdown
Member

replaced by #8513

@hsadia538 hsadia538 mentioned this pull request Feb 13, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants