Mqtt frames v6#8508
Closed
hsadia538 wants to merge 3 commits into
Closed
Conversation
Adds PDU, Header and Data frame to the MQTT parser. Ticket: 5731
Contributor
Author
|
I see check Rust CI failure but its fixing a lot of files that are unrelated to my PR. It is because of the release? there is a portion for mqtt.rs but when I run the command I don't get anything for mqtt files. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8508 +/- ##
==========================================
+ Coverage 81.84% 81.99% +0.15%
==========================================
Files 967 967
Lines 278343 278424 +81
==========================================
+ Hits 227799 228292 +493
+ Misses 50544 50132 -412
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
|
replaced by #8513 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5731
Previous PR: #8507
Describe new changes:
suricata-verify-pr: 1065