Mqtt frames v8#8540
Closed
hsadia538 wants to merge 2 commits into
Closed
Conversation
Adds PDU, Header and Data frame to the MQTT parser. Ticket: 5731
This was referenced Feb 13, 2023
Closed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8540 +/- ##
==========================================
+ Coverage 81.84% 81.91% +0.07%
==========================================
Files 967 967
Lines 278343 278480 +137
==========================================
+ Hits 227799 228122 +323
+ Misses 50544 50358 -186
Flags with carried forward coverage won't be shown. Click here to find out more. |
inashivb
requested changes
Feb 18, 2023
| Pdu, | ||
| Header, | ||
| Data, | ||
| TruncData, |
Member
There was a problem hiding this comment.
Following the discussion that happened privately, this data frame type does not seem to be necessary as we cannot annotate something that does not exist. Even if the data is truncated, the parsed parts can be tagged with Pdu, so, we can get rid of this. Make sure to add tests corresponding to truncated data. e.g.
aaaaaaaaaaaaaaabbbbbbbbbb
where a..a == data exactly the length limit
b..b == extra data that should ideally be truncated by the parser.
So, you have three tests.
- Well within the boundary.
check for say first 4B of data inPdu, it should match. - Boundary test. Should match.
check for allaaaaexactly up to the length limit. - Post boundary test. Should not match.
check foraaaa...bbbi.e. good data + truncated data
This was referenced Apr 15, 2023
Closed
Contributor
Author
|
followed by #8730 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5731
Previous PR: #8508
Describe new changes:
trunc.dataframes to cater for truncated packetssuricata-verify-pr: 1123