Mqtt frames v5#8507
Closed
hsadia538 wants to merge 17 commits into
Closed
Conversation
Flow stream/detect/log flush packets, don't hold on to the flow beyond the flow worker module.
Packets only ever reference the flow while holding its lock. This means than any code possibly evicting the flow will have to wait for the existing users to complete their work. Therefore the use_cnt serves no function anymore and can be removed.
Enforce assumption that packets in ThreadVars::decode_pq have no flow attached to it because this is only true for packets while they are in the FlowWorker.
In IPS mode set all exception policies to drop-flow by default, both in the default yaml and if no `exception-policy` is defined.
Be more informative where a exception value came from: defaults, master switch or an explicit setting.
Adds PDU, Header and Data frame to the MQTT parser. Ticket: 5731
hsadia538
requested review from
jasonish,
jufajardini and
victorjulien
as code owners
Contributor
Author
|
Followed by #8508 |
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
May 19, 2026
Instead of just on re-alloc. Ticket: OISF#8507
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5731
Previous PR: #8506
Describe new changes:
suricata-verify-pr: 1065