Skip to content

Fix StackOverflowException in analyzer tests by bypassing Roslyn SDK WeightedMatch Issue #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bradwilson merged 2 commits into from
Apr 18, 2026
Merged

Fix StackOverflowException in analyzer tests by bypassing Roslyn SDK WeightedMatch Issue #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a45761
Fix StackOverflowException in analyzer tests by disabling CompilerDia…
ana1250 Apr 18, 2026
46166ff
Additional fixes for stack overflow on macOS tests
bradwilson Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
351 changes: 170 additions & 181 deletions ...ests/Analyzers/X3000/X3000_CrossAppDomainClassesMustBeLongLivedMarshalByRefObjectTests.cs
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions ...yzers.tests/Analyzers/X3000/X3002_DoNotTestForConcreteTypeOfJsonSerializableTypesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
using System.Threading.Tasks;
using Microsoft.CodeAnalysis.CSharp;
using Xunit;
using Verify = CSharpVerifier<Xunit.Analyzers.DoNotTestForConcreteTypeOfJsonSerializableTypes>;

namespace Xunit.Analyzers;

public class X3002_DoNotTestForConcreteTypeOfJsonSerializableTypesTests
{
[Fact]
Expand Down
31 changes: 12 additions & 19 deletions src/xunit.analyzers.tests/Analyzers/X3000/X3006_TestCaseMustBeSerializableTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,42 +1,35 @@
using System.Threading.Tasks;
using Microsoft.CodeAnalysis.Testing;
using Xunit;
using Verify = CSharpVerifier<Xunit.Analyzers.TestCaseMustBeSerializable>;

public class X3006_TestCaseMustBeSerializableTests
{
static string CS0535(
string interfaceName,
int memberCount)
{
var result = interfaceName;

while (memberCount-- > 0)
result = $"{{|CS0535:{result}|}}";

return result;
}

[Fact]
public async ValueTask V3_only_NonAOT()
{
var source = $$"""
var source = """
using Xunit.Sdk;

[assembly: RegisterXunitSerializer(typeof(MySerializer), typeof(ExternalSerializedTestCase))]

public class NonTestCase { }

public abstract class AbstractTestCase : {{CS0535("ITestCase", 19)}} { }
public abstract class AbstractTestCase : ITestCase { }

public sealed class SelfSerializedTestCase : {{CS0535("ITestCase", 19)}}, {{CS0535("IXunitSerializable", 2)}} { }
public sealed class SelfSerializedTestCase : ITestCase, IXunitSerializable { }

public sealed class ExternalSerializedTestCase : {{CS0535("ITestCase", 19)}} { }
public sealed class ExternalSerializedTestCase : ITestCase { }

public sealed class {|xUnit3006:UnserializedTestCase|} : {{CS0535("ITestCase", 19)}} { }
public sealed class {|#0:UnserializedTestCase|} : ITestCase { }

public class MySerializer : {{CS0535("IXunitSerializer", 3)}} { }
public class MySerializer : IXunitSerializer { }
""";

await Verify.VerifyAnalyzerV3NonAot(source);
var expected = Verify.Diagnostic("xUnit3006")
.WithLocation(0)
.WithArguments("UnserializedTestCase", "Xunit.Sdk.ITestCase", "Xunit.Sdk.IXunitSerializable");

await Verify.VerifyAnalyzerV3NonAot(CompilerDiagnostics.None, source, expected);
}
}
31 changes: 12 additions & 19 deletions src/xunit.analyzers.tests/Analyzers/X3000/X3007_TestCaseMustBeSerializableTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,44 +1,37 @@
using System.Threading.Tasks;
using Microsoft.CodeAnalysis.Testing;
using Xunit;
using Verify = CSharpVerifier<Xunit.Analyzers.TestCaseMustBeSerializable>;

public class X3007_TestCaseMustBeSerializableTests
{
static string CS0535(
string interfaceName,
int memberCount)
{
var result = interfaceName;

while (memberCount-- > 0)
result = $"{{|CS0535:{result}|}}";

return result;
}

[Fact]
public async ValueTask V3_only_NonAOT()
{
var source = $$"""
var source = """
using Xunit.Sdk;

[assembly: RegisterXunitSerializer(typeof(MySerializer), typeof(ExternalSerializedTestCase))]

public class NonTestCase { }

public abstract class AbstractTestCase : {{CS0535("ITestCase", 19)}} { }
public abstract class AbstractTestCase : ITestCase { }

public class SelfSerializedTestCase : {{CS0535("ITestCase", 19)}}, {{CS0535("IXunitSerializable", 2)}} { }
public class SelfSerializedTestCase : ITestCase, IXunitSerializable { }

public class ExternalSerializedTestCase : {{CS0535("ITestCase", 19)}} { }
public class ExternalSerializedTestCase : ITestCase { }

public class DerivedTestCase : ExternalSerializedTestCase { }

public class {|xUnit3007:UnserializedTestCase|} : {{CS0535("ITestCase", 19)}} { }
public class {|#0:UnserializedTestCase|} : ITestCase { }

public class MySerializer : {{CS0535("IXunitSerializer", 3)}} { }
public class MySerializer : IXunitSerializer { }
""";

await Verify.VerifyAnalyzerV3NonAot(source);
var expected = Verify.Diagnostic("xUnit3007")
.WithLocation(0)
.WithArguments("UnserializedTestCase", "Xunit.Sdk.ITestCase", "Xunit.Sdk.IXunitSerializable");

await Verify.VerifyAnalyzerV3NonAot(CompilerDiagnostics.None, source, expected);
}
}
Loading
Loading