Fix StackOverflowException in analyzer tests by bypassing Roslyn SDK WeightedMatch Issue#208
Merged
bradwilson merged 2 commits intoxunit:rel/2.0.0from Apr 18, 2026
Merged
Conversation
…gnostics verification
Member
|
Still broken, presumably because I use this technique elsewhere besides your newly introduced tests. I just don't PR my own stuff, so I don't trip this (the CI build only runs on Windows). I'll pull your branch on my Mac mini and see if I can fix the rest. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This PR addresses a StackOverflowException observed when running analyzer tests
(X3006 and X3007), particularly on macOS CI, discovered while working on
#207.
The issue appears to be triggered by the diagnostic matching logic in
Microsoft.CodeAnalysis.Testing (see dotnet/roslyn-sdk#1253), where a large number
of similar compiler diagnostics can lead to very deep recursion in the matching
algorithm.
The previous tests used the {{CS0535("ITestCase", 19)}} pattern, which produces
many identical compiler diagnostics for missing interface implementations. These
diagnostics are not relevant to the analyzer behavior being tested, but they
significantly increase matching complexity.
Fix
This change simplifies the tests and avoids generating large numbers of compiler
diagnostics:
: ITestCase)CompilerDiagnostics.Nonefor these cases,since compiler errors (CS0535) are expected but not relevant to analyzer behavior
VerifyAnalyzerV3NonAotto support configuring compiler diagnosticsThis keeps the tests focused on validating analyzer behavior (xUnit3006/xUnit3007)
while avoiding excessive diagnostic matching.
Notes
Related