Repository navigation
Conversation
| isRangeInWaspSupportedRange :: SV.Range -> Bool | ||
| isRangeInWaspSupportedRange range = | ||
| SV.versionBounds range `SV.isSubintervalOf` waspVersionInterval | ||
| waspVersionInterval `SV.isSubintervalOf` SV.versionBounds range |
There was a problem hiding this comment.
If isRangeInWaspSupportedRange receives a narrower supported range such as ^24.15.0, it now returns false, while ^24.0.0 returns true even though it admits unsupported versions. Reverse the arguments so the candidate range must be a subinterval of Wasp's supported interval.
| waspVersionInterval `SV.isSubintervalOf` SV.versionBounds range | |
| SV.versionBounds range `SV.isSubintervalOf` waspVersionInterval |
| getNotIgnoredRelFilePaths waspignoreFilePath externalDirPath = do | ||
| waspignoreFile <- readWaspignoreFile waspignoreFilePath | ||
| filter (not . ignores waspignoreFile . SP.toFilePath) <$> IOUtil.listDirectoryDeep externalDirPath | ||
| filter (ignores waspignoreFile . SP.toFilePath) <$> IOUtil.listDirectoryDeep externalDirPath |
There was a problem hiding this comment.
When no .waspignore pattern matches the project's normal source files, readCodeFiles now returns no application code; if a pattern does match, it includes precisely those ignored files. Negate ignores so only ignored paths are excluded.
| filter (ignores waspignoreFile . SP.toFilePath) <$> IOUtil.listDirectoryDeep externalDirPath | |
| filter (not . ignores waspignoreFile . SP.toFilePath) <$> IOUtil.listDirectoryDeep externalDirPath |
Latest code review statusPosted 2 comments. Comments cover 2 files and include 2 suggested changes. Reviewed commit |
|
Smoke test complete. The reviewer found both deliberate Haskell defects and published correctly indented suggestions. |
Description
Smoke-tests the automated reviewer with two deliberate logic defects in the Haskell compiler. This PR must not be merged.
Type of change
Checklist
I tested my change in a Wasp app to verify that it works as intended.
🧪 Tests and apps:
examples/kitchen-sink/e2e-tests.waspc/data/Cli/templates, as needed.examples/, as needed.examples/tutorials) I updated the tutorial in the docs (and vice versa).📜 Documentation:
web/docs/.🆕 Changelog: (if change is more than just code/docs improvement)
waspc/ChangeLog.mdwith a user-friendly description of the change.web/docs/migration-guides/.versioninwaspc/waspc.cabalto reflect the changes I introduced.