Skip to content

Test automated review on Haskell changes - #4620

Closed
infomiho wants to merge 1 commit into
miho/wasp-review-skillfrom
miho/code-review-haskell-smoke
Closed

infomiho wants to merge 1 commit into
miho/wasp-review-skillfrom
miho/code-review-haskell-smoke

Conversation

@infomiho

@infomiho infomiho commented Aug 5, 2026

Copy link
Copy Markdown
Member

Description

Smoke-tests the automated reviewer with two deliberate logic defects in the Haskell compiler. This PR must not be merged.

Type of change

  • 🔧 Just code/docs improvement
  • 🐞 Bug fix
  • 🚀 New/improved feature
  • 💥 Breaking change

Checklist

  • I tested my change in a Wasp app to verify that it works as intended.

  • 🧪 Tests and apps:

    • I added unit tests for my change.
    • (if you fixed a bug) I added a regression test for the bug I fixed.
    • (if you added/updated a feature) I added/updated e2e tests in examples/kitchen-sink/e2e-tests.
    • (if you added/updated a feature) I updated the starter templates in waspc/data/Cli/templates, as needed.
    • (if you added/updated a feature) I updated the example apps in examples/, as needed.
      • (if you updated examples/tutorials) I updated the tutorial in the docs (and vice versa).
  • 📜 Documentation:

    • (if you added/updated a feature) I added/updated the documentation in web/docs/.
  • 🆕 Changelog: (if change is more than just code/docs improvement)

    • I updated waspc/ChangeLog.md with a user-friendly description of the change.
    • (if you did a breaking change) I added a step to the current migration guide in web/docs/migration-guides/.
    • I bumped the version in waspc/waspc.cabal to reflect the changes I introduced.

@infomiho
infomiho requested a review from a team as a code owner August 5, 2026 10:27
@infomiho
infomiho requested review from FranjoMindek and removed request for a team August 5, 2026 10:27

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated code review findings.

isRangeInWaspSupportedRange :: SV.Range -> Bool
isRangeInWaspSupportedRange range =
SV.versionBounds range `SV.isSubintervalOf` waspVersionInterval
waspVersionInterval `SV.isSubintervalOf` SV.versionBounds range

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If isRangeInWaspSupportedRange receives a narrower supported range such as ^24.15.0, it now returns false, while ^24.0.0 returns true even though it admits unsupported versions. Reverse the arguments so the candidate range must be a subinterval of Wasp's supported interval.

Suggested change
waspVersionInterval `SV.isSubintervalOf` SV.versionBounds range
SV.versionBounds range `SV.isSubintervalOf` waspVersionInterval

getNotIgnoredRelFilePaths waspignoreFilePath externalDirPath = do
waspignoreFile <- readWaspignoreFile waspignoreFilePath
filter (not . ignores waspignoreFile . SP.toFilePath) <$> IOUtil.listDirectoryDeep externalDirPath
filter (ignores waspignoreFile . SP.toFilePath) <$> IOUtil.listDirectoryDeep externalDirPath

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When no .waspignore pattern matches the project's normal source files, readCodeFiles now returns no application code; if a pattern does match, it includes precisely those ignored files. Negate ignores so only ignored paths are excluded.

Suggested change
filter (ignores waspignoreFile . SP.toFilePath) <$> IOUtil.listDirectoryDeep externalDirPath
filter (not . ignores waspignoreFile . SP.toFilePath) <$> IOUtil.listDirectoryDeep externalDirPath

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Latest code review status

Posted 2 comments. Comments cover 2 files and include 2 suggested changes.

Reviewed commit 80fc8f2.

@infomiho

infomiho commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

Smoke test complete. The reviewer found both deliberate Haskell defects and published correctly indented suggestions.

@infomiho infomiho closed this Aug 5, 2026
@infomiho infomiho mentioned this pull request Aug 5, 2026
1 of 15 tasks
@infomiho
infomiho had a problem deploying to railway-deploy-test August 5, 2026 11:09 — with GitHub Actions Failure

This branch had an error being deployed

2 failed deployments
fly-deploy-test — 80fc8f28 Deployed Aug 5, 2026 by infomiho via deploy-test / Test Fly deployment #11437
railway-deploy-test — 80fc8f28 Deployed Aug 5, 2026 by infomiho via deploy-test / Test Railway deployment #11437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant