Repository navigation
Conversation
@wasp.sh/spec
@wasp.sh/wasp-cli
@wasp.sh/wasp-cli-darwin-arm64-unknown
@wasp.sh/wasp-cli-darwin-x64-unknown
@wasp.sh/wasp-cli-linux-arm64-glibc
@wasp.sh/wasp-cli-linux-x64-glibc
@wasp.sh/wasp-cli-linux-x64-musl
commit: |
Deploying wasp-docs-on-main with
|
| Latest commit: |
e7671c4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cab3ed9e.wasp-docs-on-main.pages.dev |
| Branch Preview URL: | https://miho-wasp-review-skill.wasp-docs-on-main.pages.dev |
|
Testing the review action by marking the PR ready for review. |
Code reviewOne publishing reliability issue remains in the review schema contract. |
There was a problem hiding this comment.
Why not part of the existing ci workflow?
There was a problem hiding this comment.
I'd keep it separate because ready_for_review would need to retrigger the entire CI workflow.
| contains( | ||
| fromJSON('["OWNER", "MEMBER", "COLLABORATOR"]'), | ||
| github.event.pull_request.author_association | ||
| ) |
There was a problem hiding this comment.
In the "label PRs as external", I tried doing stuff with these tags but they don't straightforwardly signal what I think we'd like them to. I ended up using only the github.event.pull_request.head.repo.full_name == github.repository check, and I think here you can do it too.
| review: ${{ steps.review.outputs.final-message }} | ||
| steps: | ||
| - name: Checkout pull request | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 |
There was a problem hiding this comment.
We don't use sha-pinned actions anywhere else. (Yes they are good for security but they need an autoupdater too so we don't miss out on important improvements)
| - name: Checkout pull request | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| ref: refs/pull/${{ github.event.pull_request.number }}/merge |
There was a problem hiding this comment.
I'm quite sure this is already the ref when using the checkout action inside a PR trigger, i think
There was a problem hiding this comment.
It is the default for pull_request, but I'm keeping it explicit because this is also the pattern in OpenAI's official Codex review example: https://github.com/openai/codex-action/blob/dd78cb653811af44014baa08fe954e28d32c1bf9/README.md#L35-L46
| ref: refs/pull/${{ github.event.pull_request.number }}/merge | ||
| persist-credentials: false | ||
|
|
||
| - name: Fetch pull request refs |
There was a problem hiding this comment.
If it's to bound the agent to review base and head refs, why don't we use the same SHAs here as you do in the message to the agent?
| publish: | ||
| name: Publish review | ||
| needs: review | ||
| if: ${{ needs.review.result == 'success' }} |
There was a problem hiding this comment.
| if: ${{ needs.review.result == 'success' }} |
This is already the default
| with: | ||
| github-token: ${{ github.token }} | ||
| script: | |
There was a problem hiding this comment.
you're looking for this instead gh pr comment --edit-last --create-if-none ...
| env: | ||
| REVIEW_JSON: ${{ needs.review.outputs.review }} | ||
| run: | | ||
| printf '%s' "$REVIEW_JSON" | node .github/wasp-review/to-rdjson.mjs \ |
There was a problem hiding this comment.
is there a meaningful difference?
| printf '%s' "$REVIEW_JSON" | node .github/wasp-review/to-rdjson.mjs \ | |
| echo "$REVIEW_JSON" | node .github/wasp-review/to-rdjson.mjs \ |
There was a problem hiding this comment.
I think this might be much simpler if we define the schema in zod and then write it to this file with z.toJsonSchema(), so we can use the same values and types everywhere
There was a problem hiding this comment.
Implemented .github/code-review package with Zod schemas, thanks for the suggestion!
There was a problem hiding this comment.
you're lucky i didn't find any process.exit() here 🫡
b65ea4d to
bf26932
Compare
30d4fb7 to
e7671c4
Compare
| GH_TOKEN: ${{ github.token }} | ||
| PR_NUMBER: ${{ github.event.pull_request.number }} | ||
| REPOSITORY: ${{ github.repository }} | ||
| run: npm --prefix .github/code-review run publish-review |
There was a problem hiding this comment.
If a same-repository PR changes .github/code-review/package.json or commands/publish-review.ts, this step executes that PR-controlled code with pull-requests: write. A contributor can then post or resolve review content directly instead of being limited to the validated Codex result. Run the publisher from a trusted base-branch checkout or a pinned action, and keep the PR checkout only as the data being reviewed.
|
Ok, now we have Pullfrog enabled that basically does this for us:
That's basically what we wanted and I don't think we should write our own action we maintain anymore. Let's see if we like Pullfrog first? cc: @cprecioso |
sounds good, unsubscribing from this PR then |
|
Closing in favor of Pullfrog, let's see how we like it. |
Description
Adds automated PR review.
The workflow runs the
/wasp-reviewskill withgpt-5.6-solagainst trusted same-repository PRs in a read-only Codex job, then a separate trusted publisher adds up to five new inline findings, keeps or resolves existing review threads, and updates one summary comment. Draft and fork PRs are skipped.Example run: #4620
Alternatives
CodeRabbit is a reasonable replacement if we no longer want to maintain this workflow. It is free for public open-source repositories. Downside: it can read our review skill as instructions, but it cannot run the skill directly or let us choose the exact model.
pr-agent a PR review system that is also bring-your-own-key. It was the free offering of a Qodo and now it's donated to community, might be abandoned later?
kodus-ai they are a self-hosted / open-source CodeRabbit alternative. Could be all we need, but we need to maintain a service (maybe we use our Coolify instance for this and call it a day?)
Type of change
Checklist
I tested my change in a Wasp app to verify that it works as intended.
🧪 Tests and apps:
examples/kitchen-sink/e2e-tests.waspc/data/Cli/templates, as needed.examples/, as needed.examples/tutorials) I updated the tutorial in the docs (and vice versa).📜 Documentation:
web/docs/.🆕 Changelog: (if change is more than just code/docs improvement)
waspc/ChangeLog.mdwith a user-friendly description of the change.web/docs/migration-guides/.versioninwaspc/waspc.cabalto reflect the changes I introduced.No Wasp app, e2e, starter, documentation, changelog, or version changes are needed for this repository automation.