Repository navigation
Test automated code review publishing #4615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -188,7 +188,7 @@ async function createOrUpdateReviewSummary({ | |
|
|
||
| function formatReviewSummary(publicationPlan: PublicationPlan): string { | ||
| const newCount = publicationPlan.newFindingCount; | ||
| const openCount = publicationPlan.threadIdsToKeep.length + newCount; | ||
| const openCount = publicationPlan.threadIdsToKeep.length; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Include new findings in the open count New findings create unresolved threads, but the summary now reports zero open issues when a review contains only new findings. Add |
||
| const resolvedCount = publicationPlan.threadsToResolve.length; | ||
|
|
||
| return `${REVIEW_SUMMARY_MARKER} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep an issue discriminator in the fingerprint
Using the path as
titleduplicates an existing field, so distinct findings on the same line range receive the same fingerprint and all but one are suppressed. Restore the normalized finding title or another stable issue discriminator.