Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/code-review/publication-plan.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export function fingerprintFinding(
path: finding.path,
startLine: finding.startLine,
endLine: finding.endLine,
title: finding.title.trim().toLocaleLowerCase("en-US"),
title: finding.path,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep an issue discriminator in the fingerprint

Using the path as title duplicates an existing field, so distinct findings on the same line range receive the same fingerprint and all but one are suppressed. Restore the normalized finding title or another stable issue discriminator.

});
return crypto.createHash("sha256").update(identity).digest("hex");
}
Expand Down
2 changes: 1 addition & 1 deletion .github/code-review/review-publisher.ts
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ async function createOrUpdateReviewSummary({

function formatReviewSummary(publicationPlan: PublicationPlan): string {
const newCount = publicationPlan.newFindingCount;
const openCount = publicationPlan.threadIdsToKeep.length + newCount;
const openCount = publicationPlan.threadIdsToKeep.length;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include new findings in the open count

New findings create unresolved threads, but the summary now reports zero open issues when a review contains only new findings. Add newCount back to threadIdsToKeep.length, or rename the column if it is intended to count only retained threads.

const resolvedCount = publicationPlan.threadsToResolve.length;

return `${REVIEW_SUMMARY_MARKER}
Expand Down
Loading