Skip to content

Test automated code review publishing - #4615

Closed
infomiho wants to merge 2 commits into
miho/wasp-review-skillfrom
miho/code-review-smoke
Closed

infomiho wants to merge 2 commits into
miho/wasp-review-skillfrom
miho/code-review-smoke

Conversation

@infomiho

@infomiho infomiho commented Aug 4, 2026

Copy link
Copy Markdown
Member

Description

Adjusts review summary open-count calculation to count only existing kept threads. This PR is an automated review smoke test and should not be merged.

Type of change

  • 🔧 Just code/docs improvement
  • 🐞 Bug fix
  • 🚀 New/improved feature
  • 💥 Breaking change

Checklist

  • I tested my change in a Wasp app to verify that it works as intended.

  • 🧪 Tests and apps:

    • I added unit tests for my change.
    • (if you fixed a bug) I added a regression test for the bug I fixed.
    • (if you added/updated a feature) I added/updated e2e tests in examples/kitchen-sink/e2e-tests.
    • (if you added/updated a feature) I updated the starter templates in waspc/data/Cli/templates, as needed.
    • (if you added/updated a feature) I updated the example apps in examples/, as needed.
      • (if you updated examples/tutorials) I updated the tutorial in the docs (and vice versa).
  • 📜 Documentation:

    • (if you added/updated a feature) I added/updated the documentation in web/docs/.
  • 🆕 Changelog: (if change is more than just code/docs improvement)

    • I updated waspc/ChangeLog.md with a user-friendly description of the change.
    • (if you did a breaking change) I added a step to the current migration guide in web/docs/migration-guides/.
    • I bumped the version in waspc/waspc.cabal to reflect the changes I introduced.

@infomiho
infomiho requested a review from a team as a code owner August 4, 2026 15:43
@infomiho
infomiho requested review from FranjoMindek and removed request for a team August 4, 2026 15:43
@github-actions

github-actions Bot commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

Code review

The changes can suppress distinct findings and undercount open review issues.

New Open Resolved
2 0 0

Reviewed commit 1eb7b338d7c0cfc3c8cc29aa21d0d48552b57c69.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated code review findings.

startLine: finding.startLine,
endLine: finding.endLine,
title: finding.title.trim().toLocaleLowerCase("en-US"),
title: finding.path,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep an issue discriminator in the fingerprint

Using the path as title duplicates an existing field, so distinct findings on the same line range receive the same fingerprint and all but one are suppressed. Restore the normalized finding title or another stable issue discriminator.

function formatReviewSummary(publicationPlan: PublicationPlan): string {
const newCount = publicationPlan.newFindingCount;
const openCount = publicationPlan.threadIdsToKeep.length + newCount;
const openCount = publicationPlan.threadIdsToKeep.length;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include new findings in the open count

New findings create unresolved threads, but the summary now reports zero open issues when a review contains only new findings. Add newCount back to threadIdsToKeep.length, or rename the column if it is intended to count only retained threads.

@infomiho

infomiho commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Closing this smoke test before running a fresh review against the updated reviewer.

@infomiho infomiho closed this Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant