Repository navigation
Conversation
Code reviewThe changes can suppress distinct findings and undercount open review issues.
Reviewed commit |
| startLine: finding.startLine, | ||
| endLine: finding.endLine, | ||
| title: finding.title.trim().toLocaleLowerCase("en-US"), | ||
| title: finding.path, |
There was a problem hiding this comment.
Keep an issue discriminator in the fingerprint
Using the path as title duplicates an existing field, so distinct findings on the same line range receive the same fingerprint and all but one are suppressed. Restore the normalized finding title or another stable issue discriminator.
| function formatReviewSummary(publicationPlan: PublicationPlan): string { | ||
| const newCount = publicationPlan.newFindingCount; | ||
| const openCount = publicationPlan.threadIdsToKeep.length + newCount; | ||
| const openCount = publicationPlan.threadIdsToKeep.length; |
There was a problem hiding this comment.
Include new findings in the open count
New findings create unresolved threads, but the summary now reports zero open issues when a review contains only new findings. Add newCount back to threadIdsToKeep.length, or rename the column if it is intended to count only retained threads.
|
Closing this smoke test before running a fresh review against the updated reviewer. |
Description
Adjusts review summary open-count calculation to count only existing kept threads. This PR is an automated review smoke test and should not be merged.
Type of change
Checklist
I tested my change in a Wasp app to verify that it works as intended.
🧪 Tests and apps:
examples/kitchen-sink/e2e-tests.waspc/data/Cli/templates, as needed.examples/, as needed.examples/tutorials) I updated the tutorial in the docs (and vice versa).📜 Documentation:
web/docs/.🆕 Changelog: (if change is more than just code/docs improvement)
waspc/ChangeLog.mdwith a user-friendly description of the change.web/docs/migration-guides/.versioninwaspc/waspc.cabalto reflect the changes I introduced.