chore(weave): remove experimental StainlessRemoteHTTPTraceServer#7185
Draft
andrewtruong wants to merge 1 commit into
Draft
chore(weave): remove experimental StainlessRemoteHTTPTraceServer#7185andrewtruong wants to merge 1 commit into
andrewtruong wants to merge 1 commit into
Conversation
The experimental stainless-generated binding is already dormant on master: the weave_server_sdk dependency group it needs is commented out (it pinned a dead git generation of the SDK), and its CI matrix entries are disabled. The next PR in this stack rebuilds RemoteHTTPTraceServer itself on the published weave-server-sdk, so the parallel class and all of its opt-in plumbing go first: - weave/trace_server_bindings/stainless_remote_http_trace_server.py, its test file, the dormant "stainless" nox shard, and the commented-out CI matrix entries - the use_stainless_server setting, its weave.init docstring entry, and the stainless branch in init_weave_get_server - the --remote-http-trace-server pytest flag, the server_class fixture, the collection filter implementing the _remote/_stainless test-file split, and the now-meaningless remote_only/stainless_only markers; test_http_behavior_remote.py is renamed to test_http_behavior.py (content unchanged) since the suffix only existed to pair with _stainless - the commented-out stainless dependency group in pyproject.toml and the AGENTS.md section documenting the flag - a stale docstring mention of the class in weave_client.py
This was referenced Jun 11, 2026
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=183d50859597834a5b646bd3743d0943ae1c72b1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the experimental
StainlessRemoteHTTPTraceServerand all of its opt-in plumbing. The binding was already dormant on master: theweave_server_sdkdependency group it needs is commented out (it pinned a dead git generation of the SDK), and its CI matrix entries are disabled — a clean install could never actually use it.The next PR in this stack (#7177) rebuilds
RemoteHTTPTraceServeritself on the published weave-server-sdk, so the parallel class goes first:weave/trace_server_bindings/stainless_remote_http_trace_server.py, its test file, the dormantstainlessnox shard, and the commented-out CI matrix entriesuse_stainless_serversetting, itsweave.initdocstring entry, and the stainless branch ininit_weave_get_server--remote-http-trace-serverpytest flag, theserver_classfixture, the collection filter implementing the_remote/_stainlesstest-file split, and the now-meaninglessremote_only/stainless_onlymarkerstest_http_behavior_remote.py→test_http_behavior.py(pure rename; the suffix only existed to pair with_stainless)pyproject.tomland the AGENTS.md section documenting the flagweave_client.pyNo dependency or lockfile changes: the removed group was commented out, so resolution is untouched.
Testing
tests/trace_server_bindings— 55 passed (against the survivingRemoteHTTPTraceServer, no SDK installed)import weavesmoke test withweave-server-sdkabsent from the env (proves no hidden dependency)--remote-http-trace-server/use_stainless_server/ the dead markers (excluding unrelated OpenAI-SDK "Stainless" header mentions)