chore(weave): import weave-server-sdk models directly#7179
Draft
andrewtruong wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=1d07d4f3f0f41666c4e7188239d2505f3bd13814 |
andrewtruong
force-pushed
the
andrew/sdk-uptake-02-client-sdk-models
branch
from
6630fbe to
6a58a0a
Compare
andrewtruong
force-pushed
the
andrew/sdk-uptake-03-direct-model-imports
branch
2 times, most recently
from
00bc434 to
81fb8de
Compare
andrewtruong
force-pushed
the
andrew/sdk-uptake-02-client-sdk-models
branch
from
6a58a0a to
801dbac
Compare
Drops the transitional `models as tsi` aliasing in favor of importing the model names directly: SDK names from weave_server_sdk.models, gap/envelope names from weave.trace_server_bindings.models. The temporary re-export of the SDK models through the bindings module (which let the migration PR keep its tsi.X references textually unchanged) is removed with it — the bindings module now contains only the gap models and batching envelopes. One deliberate exception: tests/trace/test_weave_client.py keeps an unaliased `models` module reference for its binding-facing tests, because `tsi` in that file refers to the server's interface used by the coercion-seam tests, and the module qualifier keeps the two families visibly distinct.
andrewtruong
force-pushed
the
andrew/sdk-uptake-03-direct-model-imports
branch
from
81fb8de to
79be7f0
Compare
andrewtruong
force-pushed
the
andrew/sdk-uptake-02-client-sdk-models
branch
from
801dbac to
0e5ec03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does the PR do? Include a concise description of the PR contents.
Testing
How was this PR tested?