chore(weave): move builtin object schemas to weave/shared#7166
Closed
andrewtruong wants to merge 1 commit into
Closed
chore(weave): move builtin object schemas to weave/shared#7166andrewtruong wants to merge 1 commit into
andrewtruong wants to merge 1 commit into
Conversation
The builtin object classes (Leaderboard, SavedView, AnnotationSpec, Provider, LLMStructuredCompletionModel, ...) are pydantic schemas shared by the client (which re-exports and subclasses them) and the trace server (which validates against them). Move the package out of weave/trace_server/interface into weave/shared so client code can stop importing weave.trace_server: - weave/trace_server/interface/builtin_object_classes/** -> weave/shared/builtin_object_classes/** (including generated/ schemas json) - weave/trace_server/helpers/url_safety.py -> weave/shared/url_safety.py (imported by the provider schema; also used by server image_completion) Old import paths keep working via shims; the shims pair a star re-export (for static analyzers) with a PEP 562 module __getattr__ fallback so names a module's __all__ hides (e.g. TestOnlyNestedBaseModel) still resolve. The schema generation script and dev docs now point at the new location; the generated json is byte-identical after regeneration. Server-side imports are left on the shims on purpose.
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 11, 2026
Closed
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does the PR do? Include a concise description of the PR contents.
Testing
How was this PR tested?