feat(weave)!: make the SDK-backed trace server the default and remove RemoteHTTPTraceServer#7164
Closed
andrewtruong wants to merge 1 commit into
Closed
Conversation
… RemoteHTTPTraceServer StainlessRemoteHTTPTraceServer (backed by weave-server-sdk) is now the only remote trace server binding. init_weave constructs it unconditionally; the experimental use_stainless_server setting (WEAVE_USE_STAINLESS_SERVER) is removed; the WAL sender switches over. The hand-rolled RemoteHTTPTraceServer is deleted along with its test-side machinery: the --remote-http-trace-server pytest flag, the _remote/_stainless file-suffix collection filtering, and the now-redundant stainless nox shard and CI matrix entries (trace_server_bindings covers the single binding). Other changes of note: - The network_proxy_client fixture now routes the binding's httpx transport into the FastAPI TestClient via the binding's transport seam instead of monkeypatching weave.utils.http_requests.post. - The parallel-table-upload endpoint probe in weave_client previously reached into RemoteHTTPTraceServer._post_request_executor.__wrapped__; the binding now exposes unretried_table_create_from_digests for this purpose, keeping the client decoupled from binding internals. - tags/aliases route tests rewritten against the SDK binding, observing requests at the httpx transport boundary. BREAKING: the use_stainless_server setting is removed (it now describes the only behavior), and RemoteHTTPTraceServer is no longer importable.
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 11, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does the PR do? Include a concise description of the PR contents.
Testing
How was this PR tested?