allow attaching block off instances#213
Closed
ddymko wants to merge 1 commit intovultr:masterfrom
Closed
Conversation
3 tasks
Contributor
|
@optik-aper Please remove me from reviewers on this 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will allow you to attach block storage from instances. This works well but does cause a little bit of drift but gets cleaned up on a
applyorrefresh. We will need to update the docs saying that this can be a bit drifty and it may be recommended to only use this if you must and if you do to ignore theattached_instance_tofield on block.Here is an example tf
Once we test this a bit more I'll update the docs portion for instances
Related Issues
#176
Checklist: