Skip to content

vultr_resource_block : add waits for active#222

Merged
ErwinsExpertise merged 1 commit intovultr:masterfrom
ddymko:block-wait
Mar 25, 2022
Merged

vultr_resource_block : add waits for active#222
ErwinsExpertise merged 1 commit intovultr:masterfrom
ddymko:block-wait

Conversation

@ddymko
Copy link
Copy Markdown
Contributor

@ddymko ddymko commented Mar 25, 2022

Description

For block storage we don't wait until the status is active. This adds in a wait for block to be "active" before finishing

Related Issues

Part of #213

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@ddymko ddymko requested a review from ErwinsExpertise March 25, 2022 14:50
ErwinsExpertise
ErwinsExpertise approved these changes Mar 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ErwinsExpertise ErwinsExpertise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ErwinsExpertise ErwinsExpertise merged commit 97c0c09 into vultr:master Mar 25, 2022
@ErwinsExpertise ErwinsExpertise mentioned this pull request Mar 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ErwinsExpertise ErwinsExpertise ErwinsExpertise approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ddymko @ErwinsExpertise