Add tests for getting tags from FASTQ through chaining Giraffe and into BAM#4912
Merged
Conversation
Member
Author
|
This uses vgteam/libvgio#90 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
--comments-as-tagsis now under test withvg giraffe's chaining codepathvg surjectcommand linevg surjectnow preserves unrecognized GAF tags as tags on output alignments (and GAF input in general retains tags)vg giraffechaining mode now properly retains input tags on unmapped readsDescription
There was concern that tags might be falling out on the way from FASTQ to GAM, when Giraffe is using its chaining codepath.I found some ways that tags could indeed fall off reads (specifically, when a read was unmapped on the chaining codepath, or if we went through GAF format and then
vg surject).This adds tests for those cases and fixes them.