Skip to content

Add tests for getting tags from FASTQ through chaining Giraffe and into BAM#4912

Merged
adamnovak merged 4 commits into
masterfrom
keep-tags-chaining
May 22, 2026
Merged

Add tests for getting tags from FASTQ through chaining Giraffe and into BAM#4912
adamnovak merged 4 commits into
masterfrom
keep-tags-chaining

Conversation

@adamnovak
Copy link
Copy Markdown
Member

@adamnovak adamnovak commented May 21, 2026

Changelog Entry

To be copied to the draft changelog by merger:

  • --comments-as-tags is now under test with vg giraffe's chaining codepath
  • Surject tests now test SAM tags in GAM with an actual vg surject command line
  • vg surject now preserves unrecognized GAF tags as tags on output alignments (and GAF input in general retains tags)
  • vg giraffe chaining mode now properly retains input tags on unmapped reads

Description

There was concern that tags might be falling out on the way from FASTQ to GAM, when Giraffe is using its chaining codepath.

I found some ways that tags could indeed fall off reads (specifically, when a read was unmapped on the chaining codepath, or if we went through GAF format and then vg surject).

This adds tests for those cases and fixes them.

@adamnovak
Copy link
Copy Markdown
Member Author

This uses vgteam/libvgio#90

@adamnovak adamnovak merged commit 8066560 into master May 22, 2026
2 checks passed
@faithokamoto faithokamoto deleted the keep-tags-chaining branch May 22, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant