Skip to content

ci(canary): Drop unused canary steps, update the Packages job too - #1763

Open
agneszitte wants to merge 1 commit into
masterfrom
dev/agzi/canary-cleanup
Open

agneszitte wants to merge 1 commit into
masterfrom
dev/agzi/canary-cleanup

Conversation

@agneszitte

Copy link
Copy Markdown
Member

GitHub Issue (If applicable): Related to uno-private#2073 (Uno Themes on Uno Platform 7.0)

PR Type

  • Build or CI related changes

Description

Cleans up the canary-only steps after canaries/dev was synced with master (ecb743f7), and brings them in line with the other Uno Platform canaries (Toolkit, Extensions, Gallery, Playground, Chefs).

Removed (no longer needed)

  • The .NET 5.0.15 and 2.2.x runtime installs before the Canary Update. Updater 1.3.1 targets net8.0/net9.0 with rollForward: major, so it runs on the .NET 10 SDK each job installs first. No other canary installs them.
  • build/templates/versionOverrides.json and the two inputs that pass it. Its Uno.Wasm.Bootstrap* entries use UpdatedVersion: 0.0.0.0, which the updater never applies, and the repo no longer references Uno.Wasm.Bootstrap (it comes from the Uno.Sdk).

Added (missing compared with the other canaries)

  • The Canary Update in Build_Packages, as Toolkit and Extensions do. The canary now also packs the libraries against the latest Uno dev builds, not only the samples.
  • nventive in packageAuthor: Uno.Core.Extensions.* are published under that author, so the canary never updated them.

Nothing changes outside canaries/*: every step is gated by IsCanaryBranch.

Validated

  • nugetupdater 1.3.1 locally with the new settings: the same updates as the 10-22 nightly (Uno.Sdk.Private 7.0.0-dev.2285 → 7.0.0-dev.2423, Uno.UI.RuntimeTests.Engine 3.0.0-dev.7, Uno.Fonts.* 2.10.0-dev.12). Uno.Core.Extensions.* are now checked (already the latest).
  • Uno.Themes-packages.slnf Release build and pack with those versions (Visual Studio MSBuild, as in Build_Packages): 0 errors, 7 packages.
  • Canary run with this change: pending, tried on canaries/dev first.

PR Checklist

  • Commits must be following the Conventional Commits specification
  • Tested the changes where applicable: CI only, no app change
  • Updated the documentation as needed: not needed
  • Contains No breaking changes

Other information

Not changed here, noted for later:

  • Uno.XamlMerge.Task is pinned through the _Uno_XamlMerge_Task_Version property, which xamlmerge.targets also uses. The updater can't map that property to the package, so the canary never updates it (Toolkit's canary does: 1.34.0-dev.3).
  • Uno.ShowMeTheXAML versions (3.0.0-dev0008) don't match the updater's dev filter, so no canary updates it.

Internal Issue (If applicable):

uno-private#2073

🤖 Generated with Claude Code

- Remove the .NET 5.0.15 and 2.2.x runtime installs: updater 1.3.1 targets net8.0/net9.0 with rollForward major and runs on the job's .NET 10 SDK
- Remove versionOverrides.json: its Uno.Wasm.Bootstrap entries (UpdatedVersion 0.0.0.0) never applied, and the repo no longer references Uno.Wasm.Bootstrap
- Add nventive to packageAuthor so the Uno.Core.Extensions.* dev builds are updated
- Run the canary update in Build_Packages, so the canary also packs against the latest Uno dev builds, as Toolkit and Extensions do

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1763.eastus2.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant