Repository navigation
ci(canary): Remove the unused updater config, update nventive packages too - #1682
Open
agneszitte wants to merge 1 commit into
Open
agneszitte wants to merge 1 commit into
agneszitte wants to merge 1 commit into
Conversation
…s too - Remove build/updaterconfig.json: no pipeline passes it to the canary updater, and its Uno.Wasm.Bootstrap entries (UpdatedVersion 0.0.0.0) would never apply anyway - Add nventive to packageAuthor, so the canary also updates Uno.Core.Extensions.* and Uno.SourceGenerationTasks (published under that author), as Uno.Themes does Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1682.eastus2.azurestaticapps.net |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): Related to uno-private#2074 (Uno Toolkit on Uno Platform 7.0)
PR Type
What is the current behavior?
build/updaterconfig.jsonis not passed to the canary updater by any pipeline. ItsUno.Wasm.Bootstrap*entries (UpdatedVersion: 0.0.0.0) would never apply anyway.Uno Platform/unoplatform, so it skipsUno.Core.Extensions.*andUno.SourceGenerationTasks, which are published bynventive.What is the new behavior?
build/updaterconfig.jsonis removed.nventiveis added topackageAuthor, as in Uno.Themes#1763. On canaries,Uno.SourceGenerationTasksnow moves from 4.2.0 to the latest dev (4.3.0-dev.19 today).Uno.Core.Extensions.*are already the latest.canaries/*: the updater steps are gated byIsCanaryBranch.Validated locally
nugetupdater1.3.1 with the new settings:Uno.Sdk.Private7.0.0-dev.2285 → 7.0.0-dev.2423,Uno.WinUI.DevServer→ 7.0.0-dev.2423,Uno.UI.RuntimeTests.Engine→ 3.0.0-dev.7,Uno.XamlMerge.Task→ 1.34.0-dev.3,Uno.SourceGenerationTasks→ 4.3.0-dev.19.src/Uno.Toolkit-packages.slnfRelease build and pack (Visual Studio MSBuild, as inBuild_Packages): 0 errors, 8 packages.Uno.Toolkit.Samples.MaterialReleasenet10.0-android(the command fromstage-build-android.yml): build succeeded, signed APK produced.PR Checklist
Other information
Not changed here, noted for later:
Uno.UITest.*are published with their own package id as author, so the canary never updates them (1.1.0-dev.82 pinned, 1.1.0-dev.92 available).UnoCSharpMarkupVersionis read by the updater as a package nameduno.csharp.markup, which doesn't exist, so C# Markup is never updated by the canary (7.0.0-dev.33 is the latest today).NUGET_PACKAGESis inside the sources folder, so the updater also rewrites the.nuspecfiles of packages already in that cache (27 files in the 10-22 run). It hasn't caused a failure.🤖 Generated with Claude Code